Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-screen messages refactoring #17605

Merged
merged 5 commits into from
Jun 20, 2023
Merged

On-screen messages refactoring #17605

merged 5 commits into from
Jun 20, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jun 20, 2023

Redo how OSD messages are posted, allowing for more semantic control (like if it's an error, warning etc) and moves the data holder to Common, so it can have a nice public API accessible from anywhere, while rendering still will live in UI. Rendering can now happen on top of PPSSPP's menus too, it's no longer confined to EmuScreen.

Doesn't actually change the rendering yet, apart from that detail.

(This will eventually be used for RetroAchievement (see #17589) popups and similar, in addition to the usual messages).

@hrydgard hrydgard added User Interface PPSSPP's own user interface / UX Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. labels Jun 20, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Jun 20, 2023
@LunaMoo
Copy link
Collaborator

LunaMoo commented Jun 20, 2023

Could this be used to render info directly from the game(ie. in the future by custom cwcheat or alike) and refresh it every frame at specified position with choosen font and size?

@hrydgard
Copy link
Owner Author

I suppose, but I think we'd want to do that a bit differently since the game display might be moved relative to screen space.

Instead we'd want to introduce a way to draw stuff onto the framebuffer before the post-processing chain (though I guess sometimes you might want to draw at the end of it instead..)

@hrydgard hrydgard merged commit 9df01a5 into master Jun 20, 2023
@hrydgard hrydgard deleted the osd-refactoring branch June 20, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants