Dante's Inferno - Graphics issue - Bloom #4845

fastrizwaan · 2013-12-15T15:25:01Z

The Game, Dante's inferno, plays fine but there's graphics issue:

The background seems to be mirrored in transparency, in the 1st screeshot, we can see the burning torches are shown, in the 2nd the "cross" on the wall is overlaid.

Here's video too!
http://www.youtube.com/watch?v=AhJspRA6Og4

thedax · 2013-12-15T15:38:36Z

Looks like the same issue as Ridge Racer. Does it help if you change the rendering resolution?

dbz400 · 2013-12-15T16:05:52Z

I just tried it and not helping in this case

fastrizwaan · 2013-12-15T16:06:46Z

no change with redering resolution, tried with 1x, 2x, 3x

dbz400 · 2013-12-15T16:08:46Z

Looks like it is caused by "Render to area containing texture"

dbz400 · 2013-12-15T16:13:37Z

Comment it out get of rid of the artifact .(Note : either change to AttachFramebufferValid or AttachFramebufferInvalid , didn't help)

        } else if ((entry->addr - address) / entry->bufw < framebuffer->height) {
            WARN_LOG_REPORT_ONCE(subarea, G3D, "Render to area containing texture at %08x", address);
            // TODO: Keep track of the y offset.
            // If "AttachFramebufferValid" ,  God of War Ghost of Sparta/Chains of Olympus will be missing special effect.
            //AttachFramebufferValid(entry, framebuffer);
        }

dbz400 · 2013-12-15T16:15:40Z

@unknownbrackets , i think this one is originally used for Sword Art Online ?

unknownbrackets · 2013-12-15T16:17:06Z

What is the address of the framebuffer and the address of the entry? Some of these were before misunderstood because the framebuffer address was incorrectly masked.

That said, it's still a fact that the PSP can render half way into a buffer or from half way into one, such as happens in Breath of Fire 3. This code is actually too conservative to fix Breath of Fire 3 currently, though.

-[Unknown]

dbz400 · 2013-12-15T16:18:51Z

18:22:364 user_main W[G3D]: GLES\TextureCache.cpp:231 Render to area containing texture at 04110000

dbz400 · 2013-12-15T16:20:22Z

address of the framebuffer = 04110000
address of the entry is 04110400

unknownbrackets · 2013-12-15T16:36:27Z

How big is the framebuffer, do you see it rendering to it? What's the bufw? Sounds like we are likely guessing a wrong size for it.

-[Unknown]

dbz400 · 2013-12-16T01:30:37Z

The entry->bufw is 200 and framebuffer->height is 110
GLES

SoftGPU

dbz400 · 2013-12-16T01:34:00Z

I did try to fix the drawing_width to let say the viewport or region .It didn't help either

unknownbrackets · 2013-12-16T02:47:44Z

So if it's 512px wide, and 272px tall, then depending on the bitdepth it either ends at 04154000 or 04198000.

04110400 is most definitely inside that. Theoretically, it's just offset by 1px, but it could also be doing what that other game was doing (#4739), and offsetting x (if it's 8888.)

-[Unknown]

unknownbrackets · 2014-02-06T09:18:25Z

What bitdepth is the framebuffer/texture? Can I see a screenshot of the GE debugger?

-[Unknown]

unknownbrackets · 2014-06-07T05:44:13Z

Has this changed in the latest version at all with the framebuf size stuff?

I know it still has the subarea thing.

-[Unknown]

fastrizwaan · 2014-06-07T05:52:45Z

with v0.9.8-1051 windows 7 64 bit ppsspp, the issue still there.

unknownbrackets · 2014-06-10T07:52:10Z

Apparently this still lacks proper bloom, but now the artifact is gone.

-[Unknown]

unknownbrackets · 2014-06-12T07:55:44Z

Maybe #6300 will help this? It'd help to know the texture address when the bloom is supposed to render (might be easier with an older build where it does render wrong.)

Maybe it's using a VRAM mirror...

-[Unknown]

daniel229 · 2014-06-12T08:46:38Z

No,it does not help.Is it this address?next click is the artifact.

daniel229 · 2014-06-15T10:23:48Z

Fixed by 0b9db17 a little flickering though.

unknownbrackets · 2014-06-15T15:04:19Z

Flickering?

-[Unknown]

daniel229 · 2014-06-15T15:24:14Z

I think that bloom effect flickering.
Video(rename jpg to mp4)

unknownbrackets · 2014-06-15T15:37:36Z

It looks possibly misaligned. Maybe it's overestimating the height of a framebuffer... this happens at 1x, right? I'm guessing so.

What happens if you force drawing_height to 272? I'm guessing it's making something bigger. Maybe it's even clearing two bufers at once, y-ways, like God of War...

-[Unknown]

daniel229 · 2014-06-15T15:58:47Z

Yes,this happen at 1x, force drawing_height to 272 seems no difference.

unknownbrackets · 2014-06-15T16:03:16Z

Can you grab some of the Est lines? Maybe the problem is it's over estimating to 272...

-[Unknown]

daniel229 · 2014-06-15T16:08:37Z

Here
07:35:192 user_main 07:35:192 user_main 07:35:193 user_main 07:35:195 user_main 07:35:195 user_main 07:35:198 user_main 07:35:201 user_main 07:35:201 user_main 07:35:201 user_main 07:35:216 user_main 07:35:216 user_main 07:35:239 user_main 07:35:241 user_main 07:35:242 user_main 07:35:242 user_main 07:35:242 user_main 07:35:245 user_main 07:35:245 user_main 07:35:248 user_main 07:35:249 user_main 07:35:249 user_main 07:35:250 user_main 07:35:266 user_main 07:35:266 user_main 07:35:289 user_main 07:35:291 user_main 07:35:292 user_main 07:35:292 user_main 07:35:293 user_main 07:35:295 user_main 07:35:295 user_main 07:35:298 user_main N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:00000000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44000000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44110000 V: 512x128, R: 512x272, S: 512x128, STR: 512, THR:0, Z:44044000 = 512x128
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:00000000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44000000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44110000 V: 512x128, R: 512x272, S: 512x128, STR: 512, THR:0, Z:44044000 = 512x128
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:00000000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44000000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44110000 V: 512x128, R: 512x272, S: 512x128, STR: 512, THR:0, Z:44044000 = 512x128
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:00000000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44000000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44110000 V: 512x128, R: 512x272, S: 512x128, STR: 512, THR:0, Z:44044000 = 512x128
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:0, Z:00000000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44000000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44088000 V: 480x272, R: 512x272, S: 480x272, STR: 512, THR:1, Z:44044000 = 512x272
N[G3D]: GLES\Framebuffer.cpp:723 Est: 44110000 V: 512x128, R: 512x272, S: 512x128, STR: 512, THR:0, Z:44044000 = 512x128

Saramagrean · 2019-07-11T20:32:41Z

Temporary fix: Use PPSSPP v1.7.1 Build 171 and enable BlockTransferAllowCreateFB can play game full speed without lacking bloom. :) (but since v1.7.1 Build 181 this solution isn't work)

ghost · 2019-07-12T00:33:32Z

@Saramagrean Can I know what's your phone hardware specifications??..

ghost · 2019-07-12T02:00:15Z

This commit of sir @hrydgard 442b570 has a fixed of Dantes Inferno @Saramagrean? 🤔
Can you give me the apk link seems that I can't connect right now in ppsspp buildbot 😔

EDIT: I finally downloaded v1.7.1-171 from buildbot using vpn I will test later Dante's Inferno on this version

Saramagrean · 2019-07-12T03:52:40Z

@Saramagrean Can I know what's your phone hardware specifications??..

Huawei P9 Plus.

Saramagrean · 2019-07-12T03:54:02Z

This commit of sir @hrydgard 442b570 has a fixed of Dantes Inferno @Saramagrean? 🤔

I don't think so...

ghost · 2019-07-12T06:34:42Z

Still the same in my phone (arm32/Mali-450/OpenGL)

PPSSPP v1.7.1-171

Locking bloom effects is worst in ppsspp last build v1.8.0-407 the game is super lag also 😔

Saramagrean · 2019-07-12T08:25:19Z

@Emulatorer ...with enabled BlockTransferAllowCreatdFB in compat.ini file?

ghost · 2019-07-12T09:48:46Z

@Saramagrean Yes

ghost · 2019-07-12T09:52:35Z

But it's ok now I just need to enable other speed up in graphics settings also I use force 30fps to make this game playable on my potato phone 😌

I will play this game for a while and see if the locking bloom effects will show or not until I finish this game :)

ghost · 2019-07-14T11:01:03Z

@Saramagrean sad to say issue still persist in some area 🤷😔

Levan7 · 2019-07-14T13:52:56Z

Still an issue on PC v1.8.0-414-g27608349e

PilipinoAko · 2019-08-03T03:49:57Z

How did you do that wow

PilipinoAko · 2019-08-03T03:52:13Z

This gloom is the one of the bug can't fix but in soft gpu can play it normal in open gl still not playable i hope can fix it

ghost · 2020-03-11T13:38:23Z

PPSSPPv1.9.3-465

Can this issue label as GE Emulation or Opengl?, since this issue is a backend dependant. Some of my friends can play this without locking bloom effects using Vulkan backend in their android phones

ghost · 2020-03-12T00:25:07Z

GOOD NEWS!!!

No locking bloom effects on my tablet w/ mali-t720 gpu ogl 3.1 but still has a graphics issue though 😅

*USING PPSSPPv1.9.3-481

ghost · 2020-03-18T04:32:48Z

update

No locking bloom effects in OGL 3.1+ but characters image is transparent.

No changes in OGL 2.0+ this game always locking bloom effects so no chance for my phone w/ mali-450 gpu to play this game 😶

ghost · 2020-06-04T09:26:10Z

Here is the dump, hope it's helps.
Dumped from PPSSPP v1.8.0-112, from iPhone7(A10), iOS12.1.2 jailbroken device.
ULES01384_0001.zip

Using the dump above.

HW rendering

SW rendering

Halo-Michael · 2020-06-06T06:35:05Z

This is the graphical performance of ULES01384_1.00 in v1.9.3-975-g6f07e2b48 (A ppdmp file, and a screen recording file):
https://github.com/Halo-Michael/PPSSPP-ULES01384_0001
Dumped from SE2(A13) iOS13.5 jailbroken with Unc0ver.
The problem is still a layer of translucent flashing shadows occupying the lower half of the screen

hrydgard · 2020-08-04T21:06:23Z

Started looking into this (in the the Vulkan backend, using the GE debugger and RenderDoc)

The game does a fairly traditional bloom where you subtract some brightness from the game image, blurring that, and adding the result on top of the original image. It does this initial step by first drawing a gray rectangle, then using SUBTRACT blending to subtract it from the game image. Unfortunately that gray clear malfunctions somehow and only clears the upper half of the image, leaving garbage from the previous frame behind. This garbage being subtracted from the previous frame's garbage causes the flickering.

Apart from that, the bloom effect seems to work ok now.

The viewport seems screwed up during that clearing draw:

While normal during the next draw:

I wonder if the viewport itself should actually clip at all. As we know, the PSP clipping solution is a bit ... different.

We might need to change our viewport translation logic to extend the viewport to at least cover the scissor region to fix this. It should be possible to just use the viewport clipping logic but use it to extend instead of shrink.

…4845 (bloom in Dante's Inferno).

hrydgard · 2020-08-05T21:49:04Z

The remaining bloom flicker is now fixed.

Panderner · 2020-08-07T01:41:11Z

Good Job @hrydgard

but this game needs to be set to buffered rendering

hrydgard · 2020-08-07T05:17:09Z

Yup, no way getting around that, I think.

…hould fix #7124 for the SW renderer.

daniel229 mentioned this issue Jun 9, 2014

Assume 512 tall framebuffers are wrong too #6262

Merged

hrydgard changed the title ~~Dante's Inferno - Graphics issue - background image is superimposed~~ Dante's Inferno - Graphics issue - Lacking bloom (previously: background image is superimposed) Jun 10, 2014

hrydgard closed this as completed Jun 15, 2014

unknownbrackets reopened this Jun 15, 2014

hrydgard added this to the v1.11 milestone Mar 15, 2020

hrydgard added the GE emulation Backend-independent GPU issues label Mar 15, 2020

hrydgard changed the title ~~Dante's Inferno - Graphics issue - Lacking bloom (previously: background image is superimposed)~~ Dante's Inferno - Graphics issue - Bloom Aug 4, 2020

hrydgard added a commit that referenced this issue Aug 5, 2020

Expand the viewport to cover the scissor region, if it doesn't. Fixes #…

fd3a9d4

…4845 (bloom in Dante's Inferno).

hrydgard mentioned this issue Aug 5, 2020

Fit viewport to scissor #13251

Merged

hrydgard closed this as completed in #13251 Aug 5, 2020

hrydgard added a commit that referenced this issue Aug 16, 2020

Software renderer clipper: Don't clip on the sides. Fixes #4845 and s…

2e06386

…hould fix #7124 for the SW renderer.

hrydgard mentioned this issue Aug 16, 2020

Software renderer clipper: Don't clip on the sides. #13294

Merged

Dante's Inferno - Graphics issue - Bloom #4845

Dante's Inferno - Graphics issue - Bloom #4845

Comments

fastrizwaan commented Dec 15, 2013

thedax commented Dec 15, 2013

dbz400 commented Dec 15, 2013

fastrizwaan commented Dec 15, 2013

dbz400 commented Dec 15, 2013

dbz400 commented Dec 15, 2013

dbz400 commented Dec 15, 2013

unknownbrackets commented Dec 15, 2013

dbz400 commented Dec 15, 2013

dbz400 commented Dec 15, 2013

unknownbrackets commented Dec 15, 2013

dbz400 commented Dec 16, 2013

dbz400 commented Dec 16, 2013

unknownbrackets commented Dec 16, 2013

unknownbrackets commented Feb 6, 2014

unknownbrackets commented Jun 7, 2014

fastrizwaan commented Jun 7, 2014

unknownbrackets commented Jun 10, 2014

unknownbrackets commented Jun 12, 2014

daniel229 commented Jun 12, 2014

daniel229 commented Jun 15, 2014

unknownbrackets commented Jun 15, 2014

daniel229 commented Jun 15, 2014

unknownbrackets commented Jun 15, 2014

daniel229 commented Jun 15, 2014

unknownbrackets commented Jun 15, 2014

daniel229 commented Jun 15, 2014

Saramagrean commented Jul 11, 2019 • edited Loading

ghost commented Jul 12, 2019

ghost commented Jul 12, 2019 • edited by ghost Loading

Saramagrean commented Jul 12, 2019

Saramagrean commented Jul 12, 2019

ghost commented Jul 12, 2019

PPSSPP v1.7.1-171

Saramagrean commented Jul 12, 2019

ghost commented Jul 12, 2019

ghost commented Jul 12, 2019

ghost commented Jul 14, 2019

Levan7 commented Jul 14, 2019

PilipinoAko commented Aug 3, 2019

PilipinoAko commented Aug 3, 2019

ghost commented Mar 11, 2020

PPSSPPv1.9.3-465

ghost commented Mar 12, 2020 • edited by ghost Loading

GOOD NEWS!!!

ghost commented Mar 18, 2020

update

ghost commented Jun 4, 2020

HW rendering

SW rendering

Halo-Michael commented Jun 6, 2020 • edited Loading

hrydgard commented Aug 4, 2020 • edited Loading

hrydgard commented Aug 5, 2020

Panderner commented Aug 7, 2020

hrydgard commented Aug 7, 2020

Saramagrean commented Jul 11, 2019 •

edited

Loading

ghost commented Jul 12, 2019 •

edited by ghost

Loading

ghost commented Mar 12, 2020 •

edited by ghost

Loading

Halo-Michael commented Jun 6, 2020 •

edited

Loading

hrydgard commented Aug 4, 2020 •

edited

Loading