Adhocctl Fix - Valhalla Knights 2 #13383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenweip
reviewed
Sep 5, 2020
Core/HLE/sceNetAdhoc.cpp
Outdated
| // Already connected to a group. Should we fake a success? | ||
| // We need to notify the handler on success, even if it was faked | ||
| notifyAdhocctlHandlers(ADHOCCTL_EVENT_SCAN, 0); | ||
| hleDelayResult(0, "give a little time to be ready to receive the callback", us); |
There was a problem hiding this comment.
You can use return hleDelayResult(0, "give a little time to be ready to receive the callback", us) intead of return 0 below.
There was a problem hiding this comment.
Ah hleDelayResult have return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #13279
This should also fix an issue that occurred when creating/joining/connecting to a group, where a socket error with EAGAIN/EWOULDBLOCK supposed to be retried on the blocking simulation but didn't get retried (because i forgot to check the error code) and ended fallback to faked success