Mpeg:Improves the support of multiple streams video. #13659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls callback multiple times to read all packets when the write position reaches the boundary of the ringbuffer.
…m() not only the mpegheader.
shenweip
changed the title
|
Code looks good. Let's try it. |
|
this will broke Jeanne d'Arc and Open Season unfortunately. |
|
Don't worry, I know how to fix now:) |
| @@ -1495,6 +1496,9 @@ void PostPutAction::run(MipsCall &call) { | |||
| // Program signals that it has written data to the ringbuffer and gets a callback ? | |||
| static u32 sceMpegRingbufferPut(u32 ringbufferAddr, int numPackets, int available) | |||
| { | |||
| // Generally, program will call sceMpegRingbufferAvailableSize() before this func. | |||
| // Still need to check available? | |||
There was a problem hiding this comment.
See #978. I think we should test this, though, for the correct behavior. Ideally we should replicate (as far as is visible) what firmware does.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8526.
That game has strict requirements for the number of video frames. If no enough packets are read, the game will hang.
And the videos it uses have 4 video streams, but the mpegheader seems don't have the correct stream info.