Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BlockTransferAllowCreateFB for Gradius Collection #13911

Merged
merged 2 commits into from
Jan 17, 2021

Conversation

Panderner
Copy link
Contributor

This PR increases performance for Gradius Collection to all games (except Gradius IV).

If I disable Simulate block transfer effects for all games except Gradius IV the video freezes.

Unfortunately all games are extremely lag for lower-end devices however Gradius IV works fine for 1.5 GHz quad core Mali-400MP2 device.

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jan 12, 2021
@hrydgard hrydgard added this to the v1.12.0 milestone Jan 12, 2021
@hrydgard
Copy link
Owner

hrydgard commented Jan 17, 2021

If the game looks exactly the same with this change, and you've played more than a few levels, I'm happy to merge.

@hrydgard hrydgard modified the milestones: v1.12.0, v1.11.0 Jan 17, 2021
@Panderner
Copy link
Contributor Author

Oh yes there's a difference that BlockTransferAllowCreateFB disables linear filtering for upscaled resolutions for Gradius 1, Gradius 2 and Gradius Gaiden.

BlockTransferAllowCreateFB off:
Screenshot_2021-01-17-18-42-17-889_org ppsspp ppsspp

BlockTransferAllowCreateFB on:
Screenshot_2021-01-17-18-41-10-685_org ppsspp ppsspp

@hrydgard
Copy link
Owner

Oh, hm, that's interesting. Might be a bug, not sure? Either way, if that's the only difference, I think we're good.

@hrydgard hrydgard merged commit 58d80e5 into hrydgard:master Jan 17, 2021
@Panderner Panderner deleted the gradius-speed-hack branch January 17, 2021 11:53
@Panderner
Copy link
Contributor Author

This PR is now merged can we revert #13929?

@unknownbrackets
Copy link
Collaborator

If it's drawing at a higher resolution and aniso is on, those results are expected right?

It does require block transfer, doesn't it?

-[Unknown]

@Panderner
Copy link
Contributor Author

If it's drawing at a higher resolution and aniso is on, those results are expected right?

It does require block transfer, doesn't it?

-[Unknown]

It only used for Gradius 1, Gradius 2 and Gradius Gaiden. It does not require Block transfer for Gradius 3 and 4. and now Ys Seven is no longer require to turn on block transfer effects due to BlockTransferAllowCreateFB is enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants