Try to improve sceMp3Decode #13951
Closed
Try to improve sceMp3Decode #13951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Hanayaka Nari Wa ga Ichizoku JPCSPTrace log
| // decode data successfully, delay thread | ||
| return hleDelayResult(pcmBytes, "mp3 decode", mp3DecodeDelay); | ||
| } | ||
| return pcmBytes; | ||
| ERROR_LOG(ME, "%d = sceMp3Decode(%08x,%08x)", 0x807f00fd, mp3, outPcmPtr); | ||
| return ERROR_AVCODEC_INVALID_DATA; |
There was a problem hiding this comment.
The only negative case right now would be invalid address:
ppsspp/Core/HW/SimpleAudioDec.cpp
Line 332 in b76e906
This probably won't change anything. If we're seeing the JpcspTrace return an error it may mean we need better validation.
-[Unknown]
There was a problem hiding this comment.
JPCSP also don't have have this error code in sceMp3Decode.
I should wait it first.
|
How about this now? |
|
I think the issue was fixed by #13981, and the code currently incorporates a similar change. Thanks for helping getting this fixed - I'm gonna close this PR. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Hanayaka Nari Wa ga Ichizoku JPCSPTrace log https://gist.github.com/sum2012/e2d513c55342c40f5e12
But don't help the game #5213