-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adhoc] Fix The Warriors #13967
[adhoc] Fix The Warriors #13967
Conversation
Do we have an issue about this, to tag for closing? Looks okay, although it seems very odd to call send without connect. |
There are no issue opened related to networking on The Warriors. Yeah it's an odd way to connect, i still need to test the behavior of PtpOpen to see whether it's possible to send without connecting first. |
After testing it on a small homebrew, looks like the error code returned from PtpSend was wrong, it should be "disconnected" instead of "not connected", and looks like PtpSend can get a success after PtpOpen (the other side was able to PtpAccept after PtpListen) |
…rriors) seems to do PtpSend immediately after PtpOpen without trying to PtpConnect first.
Okay i'm done. So basically, |
Oh, that's making more sense indeed. |
Fixes the new problem in #13967 Though of course doesn't fix the vertical lines.
Apparently there are games (ie. The Warriors) who tried to do PtpSend immediately after PtpOpen, without trying to do PtpConnect first.