GPU: Respect stencil write mask for 5551 buffers #13972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the mask is 0x7F on 5551, that's equivalent to allowing the clear entirely. See hrydgard#13391.
Doesn't seem like the color mask applies to clears.
|
Looks good! Wonder if we also need to do something for 4444 format, although it's much rarer due to the poor color quality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the mask is 0x7F on 5551, that's equivalent to allowing the clear entirely. See #13391, hoping this fixes it based on the dump.
Also see #11902. I don't think that
dxstate.colorMaskapplies to clears, so I set it the same way as everything but GLES.It's a shame that games do a separate clear for color/stencil and then depth sometimes...
-[Unknown]