Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command in developer tools to list and load framedumps from the web #14037

Merged
merged 5 commits into from
Jan 31, 2021

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 31, 2021

Useful for reproducing and reporting rendering bugs to vendors. No need for them to copy files around and so on. Loads from framedump.ppsspp.org/repro/ .

image

… framedump.ppsspp.org/repro/

Useful to make it easy to test GPU driver bugs etc, without having to
use real games or copying files around.
@hrydgard hrydgard added GE emulation Backend-independent GPU issues User Interface PPSSPP's own user interface / UX labels Jan 31, 2021
@hrydgard hrydgard added this to the v1.11.0 milestone Jan 31, 2021
@hrydgard hrydgard changed the title Add a command in developer tools to list and load framedumps from framedump.ppsspp.org/repro/ Add a command in developer tools to list and load framedumps from the web Jan 31, 2021
@hrydgard hrydgard merged commit a6b9744 into master Jan 31, 2021
@hrydgard hrydgard deleted the framedump-test branch January 31, 2021 15:12
std::string url = params.v->Tag();
INFO_LOG(COMMON, "Trying to launch '%s'", url.c_str());
// Our disc streaming functionality detects the URL and takes over and handles loading framedumps well,
// except for some reason the game ID.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should embed the game ID in dumps now and use that - see #13396. This is only in newer dump files.

-[Unknown]

Copy link
Owner Author

@hrydgard hrydgard Jan 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of that, but I took fresh frame dumps, and looked at the logs when loading them through http this way. They do not manage to load the game ID. Have not yet debugged it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, for me it reaches coreParameter.compat.Load(discID); with the value "ULUS10336". It still logs generating a fake one because that logic never affected the SFO code.

-[Unknown]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I guess the logs are a bit misleading then, and thus, this comment is too :)

I didn't look into it carefully, just noted that we generated an ID...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants