-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command in developer tools to list and load framedumps from the web #14037
Conversation
… framedump.ppsspp.org/repro/ Useful to make it easy to test GPU driver bugs etc, without having to use real games or copying files around.
std::string url = params.v->Tag(); | ||
INFO_LOG(COMMON, "Trying to launch '%s'", url.c_str()); | ||
// Our disc streaming functionality detects the URL and takes over and handles loading framedumps well, | ||
// except for some reason the game ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should embed the game ID in dumps now and use that - see #13396. This is only in newer dump files.
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware of that, but I took fresh frame dumps, and looked at the logs when loading them through http this way. They do not manage to load the game ID. Have not yet debugged it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, for me it reaches coreParameter.compat.Load(discID);
with the value "ULUS10336". It still logs generating a fake one because that logic never affected the SFO code.
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I guess the logs are a bit misleading then, and thus, this comment is too :)
I didn't look into it carefully, just noted that we generated an ID...
Useful for reproducing and reporting rendering bugs to vendors. No need for them to copy files around and so on. Loads from framedump.ppsspp.org/repro/ .