Windows debugger: Load the dialogs on demand. #15138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is especially good for the Ge dialog since we now can avoid initializing that extra GL context unless you open the dialog.
|
Just gonna go ahead and merge. There's a small risk it might regress some secondary path for opening these dialogs, but if so, should be easy to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is especially good for the GeDebugger dialog since we now can avoid initializing that extra GL context unless you open the dialog.
This actually saves as much as a second of startup time on Windows. Maybe doesn't seem important, but when developing and iterating on stuff, the less you have to wait the better.
Additionally, optimizes CleanRecent for an extra 150ms savings (in my testing).
See #15137