softgpu: Correctly fix inversions, matching tests #16470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inversions are allowed just fine, but if clipping results in coordinates outside range, the triangle should be culled. Fixes more wanted inversions.
|
Very nice, and makes total sense, hah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inversions are allowed just fine, but if clipping results in coordinates outside range, the triangle should be culled. Fixes more wanted inversions.
It feels stupidly obvious now why the particular Z value I found was such an arbitrary threshold, it was causing the screen coordinates to go out of bounds. I should've been checking them.
This seems to cull in all the correct places, at least in the frame dumps I've gathered. I haven't tested some of the latest from #16131 yet but this makes a lot of sense and matches the previous ones.
Fixes the case in #16207 (better than hardware, there's an innocent inversion Vulkan/etc. draw which the PSP doesn't), fixes #15875. Takes care of #11376 in software only, as well as #10914 (both of those are still issues in hardware renderers.)
-[Unknown]