Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softgpu: Fix double rectangle drawing at halfpixel #16503

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

unknownbrackets
Copy link
Collaborator

There seems to be some odd behavior with the X start pos, but at least the end pos should not be drawn twice when using 0.5 - 0.5.

This unfortunately only fixes some of the cases from #16131, as there are more problems after all. It helps:

  • Frogger, which no longer draws a pixel twice.
  • Dig Dug, same.
  • MTX Mototrax, but only one of the lines, so there's more to it.
  • Phantasy Star Portable 1, from not overdrawing.

I also checked several of the usual suspects (Valkyrie Profile, bloom in Call of Duty, etc.) which render correctly.

Triangles need some tweaks too, but there's some complexities there, and this fixes bugs already by itself.

-[Unknown]

There seems to be some odd behavior with the X start pos, but at least the
end pos should not be drawn twice when using 0.5 - 0.5.
@unknownbrackets unknownbrackets added this to the v1.14.0 milestone Dec 5, 2022
@hrydgard hrydgard merged commit e44e9b6 into hrydgard:master Dec 5, 2022
@unknownbrackets unknownbrackets deleted the softgpu-halfpos branch December 5, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants