Model impl #7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| node_modules | ||
| js/result.js | ||
| .idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| 'use strict'; | ||
| export default class EventEmitter { | ||
| listeners = {}; | ||
| observables = {}; | ||
|
|
||
| /* | ||
| methods for observable object | ||
| */ | ||
| // subscribe to event | ||
| on(eventName, handler) { | ||
| if (typeof this.listeners[eventName] === 'undefined') { | ||
| this.listeners[eventName] = []; | ||
| } | ||
| this.listeners[eventName].push(handler); | ||
| } | ||
| // rise the event | ||
| emit(eventName, ...args) { | ||
| if (typeof this.listeners[eventName] !== 'undefined') { | ||
| this.listeners[eventName].forEach(func => { | ||
| func(eventName, ...args); | ||
| }); | ||
| } | ||
| } | ||
| //unsubscribe from event | ||
| off(eventName, handler) { | ||
| if (typeof this.listeners[eventName] !== 'undefined') { | ||
| this.listeners[eventName] = this.listeners[eventName].filter(listen => handler != listen); | ||
| } | ||
| } | ||
| //remove all subscribers | ||
| removeAll(eventName) { | ||
| delete this.listeners[eventName]; | ||
| } | ||
|
|
||
| /* | ||
| methods for listener object | ||
| */ | ||
|
|
||
| // connect handler method to listen eventName of observable object | ||
| listenTo(observable, eventName, handler) { | ||
| if (typeof observable.on === 'undefined' || | ||
| typeof observable.off === 'undefined') { | ||
| throw new Error('There are not "on" or "off" methods'); | ||
| } | ||
| observable.on(eventName, handler); | ||
| if (typeof this.observables[eventName] === 'undefined') { | ||
| this.observables[eventName] = []; | ||
| } | ||
| this.observables[eventName].push({observable, handler}); | ||
|
|
||
| } | ||
|
|
||
| unlistenFrom(observable, eventName) { | ||
| observable.off(eventName, this.observables[eventName].handler); | ||
| if (typeof this.observables[eventName] !== 'undefined') { | ||
| this.observables[eventName] = this.observables[eventName].filter(obs => obs.observable !== observable); | ||
| } | ||
| } | ||
|
|
||
| unlistenAll() { | ||
| for (let key in this.observables) { | ||
| this.observables[key].forEach(obs => obs.observable.off(key, obs.handler)); | ||
| delete this.observables[key]; | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| module.exports={ | ||
| save: (store)=>{ | ||
| //TODO better to surround it by try-catch | ||
| localStorage.setItem('store', JSON.stringify(store)); | ||
| }, | ||
| load: ()=>{ | ||
| return JSON.parse(localStorage.getItem('store')); | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,5 +2,6 @@ | |
| 'use strict'; | ||
|
|
||
| // Your starting point. Enjoy the ride! | ||
| // Write npm run watch-js to start coding | ||
|
|
||
| })(window); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| 'use strict'; | ||
| const api = require('./api'); | ||
|
|
||
| class Model { | ||
| var store = { | ||
|
There was a problem hiding this comment. В es6 нельзя так инициализировать поля. Их надо заполнять в конструкторе. |
||
| lastId: -1, | ||
| todo: [ | ||
| { | ||
| id: 0, | ||
| name: 'task for test', | ||
| isCompleted: false | ||
| } | ||
| ] | ||
| }; | ||
| constructor(){ | ||
| this.addTask = this.addTask.bind(this); | ||
| this.removeTask = this.removeTask.bind(this); | ||
| this.toggleTask = this.toggleTask.bind(this); | ||
| this.removeAll = this.removeAll.bind(this); | ||
| this.save = this.save.bind(this); | ||
| this.load = this.load.bind(this); | ||
| } | ||
| addTask(name, isCompleted = true) { | ||
| var id = this.store.lastId + 1; | ||
| this.store.todo.push({id:id, name: name, isCompleted: isCompleted}); | ||
| this.store.lastId = id; | ||
| return id; | ||
| } | ||
| removeTask(id){ | ||
| this.store.todo = this.store.todo.filter(todo => todo.id !== id); | ||
| } | ||
| toggleTask(id){ | ||
| this.store.todo = this.store.map(todo =>{ | ||
| if (todo!== id) | ||
| return todo; | ||
| else { | ||
| todo.isCompleted = !todo.isCompleted; | ||
| return todo; | ||
| } | ||
| }); | ||
| } | ||
| removeAll(){ | ||
| this.store.todo = []; | ||
| this.store.lastId = -1; | ||
| } | ||
| save(){ | ||
| api.save(this.store); | ||
| } | ||
| load(){ | ||
| this.store = api.load(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| module.exports = Model; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| const Handlebars = require('handlebars'); | ||
|
|
||
| var source = $("todo").html(); | ||
|
There was a problem hiding this comment. Ты обращаешься к элементу по id, а не по тегу. Нужно писать $("#todo") |
||
| var template = Handlebars.compile(source); | ||
| var context = { todo: [{name: "first task"}, {name:"second task"}] }; | ||
| var html = template(context); | ||
| $("document").append(html); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,14 @@ | ||
| { | ||
| "private": true, | ||
| "dependencies": { | ||
| "browserify": "^13.1.1", | ||
| "handlebars": "^4.0.6", | ||
| "todomvc-app-css": "^2.0.0", | ||
| "todomvc-common": "^1.0.0", | ||
| "watchify": "^3.7.0" | ||
| }, | ||
| "scripts": { | ||
| "build-js": "browserify js/app.js > js/result.js", | ||
| "watch-js": "watchify js/app.js -o js/result.js" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Скрипт добавлен в страницу, а через browserify ты его не прогнал.
Нужно добавить его сборку в package.json/scripts, либо сделать require в app.js (recommended).