Implement serialization and deserialization for file dict #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asikowitz
commented
Mar 1, 2023
Comment on lines
+125
to
+129
| n_deleted = self._conn.execute( | ||
| "DELETE FROM data WHERE key = ?", (key,) | ||
| ).rowcount | ||
| if not in_cache and not n_deleted: | ||
| raise KeyError(key) |
There was a problem hiding this comment.
Doing self[key] will cause a deserialization call, so I reimplemented using the rowcount returned by the delete call
Comment on lines
+159
to
+160
| def __del__(self) -> None: | ||
| self.close() |
There was a problem hiding this comment.
Just in case we forget to close, do it on garbage collection. Have confirmed close() can be called multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the large-pr in acryldata flow, but in your personal branch.
I opted to make serializer and deserializer required arguments, because adding defaults as json.dumps and json.loads respectively would add extra overhead for basic
FileBackedDict[str]orFileBackedDict[int]objects, when the identify function would be sufficient. I don't think it's too onerous to have to specify your serializer and deserializer, even if it's just the identity function or json functions, and in general something the user should be thinking about when they're usingFileBackedDictChecklist