Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxplot readme description + properties #102

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

trainorpj
Copy link
Contributor

This adds documentation to vx/boxplot. It was brought up (by me) in this issue.

I tried to follow the style in the rest of the documentation, so I added

  • A short description of what a boxplot is
  • A table documenting the properties of the <BoxPlot /> component

Questions I have:

  • Is this written in the correctly?
  • Is more information necessary?
  • Is a picture necessary?

P.S. This is my first PR (ever!), so please let me know if there's anything I missed. I'm still learning to etiquette of OSS 👶

@williaster
Copy link
Collaborator

@trainorpj thanks for your interest in vx and for making the docs better for everyone! 🎉

The description looks good to me and with the PropTable I think it's complete enough to get someone up and running 👍 Congrats on your first PR 👏

@williaster williaster merged commit ac0f56f into airbnb:master Jul 17, 2017
@williaster williaster added this to the v0.0.131 milestone Jul 17, 2017
@trainorpj trainorpj deleted the write-boxplot-readme branch July 18, 2017 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants