Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of shaders in string literals does not work with some strings #68

Closed
hsimpson opened this issue Sep 4, 2023 · 1 comment
Closed
Assignees
Labels

Comments

@hsimpson
Copy link
Owner

hsimpson commented Sep 4, 2023

Example JS Code (Shader Code is not conform!!!):

const vertexShaderSource = `#version 300 es
#pragma vscode_glsllint_stage: vert

void main()
{
    gl_Position = vec4(0.0,0.0,0.0,1.0);
}`;

const fregmentShderSource = `
#version 300 es
#pragma vscode_glsllint_stage: frag
main() ERROR HERE FOR TRIGER THE VALIDATOR 
{
    gl_FragColor = vec4(1.0,0.0,0.0,1.0);
}`;

const c = document.querySelector('canvas');
const gl = c.getContext('webgl2');
const program = gl.createProgram();
gl.useProgram(program);
@hsimpson hsimpson added the bug label Sep 4, 2023
@hsimpson hsimpson self-assigned this Sep 4, 2023
hsimpson added a commit that referenced this issue Sep 4, 2023
…string-literals

fix: shader detection of string literals
@hsimpson hsimpson closed this as completed Sep 4, 2023
@hsimpson
Copy link
Owner Author

hsimpson commented Sep 4, 2023

Fixed with 1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant