Add command line args setting option for the GLSL validator executable #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using your extension for linting my shader code, and it worked great until I started using push constants in my shaders. Push constants are a SPIR-V only type, so it caused the extension to stop evaluating my shader code after it found a push constant block like this:
The GLSL validator I am using supports code like above, but it requires the command line argument
-V
. I altered your extension so that it could handle command line arguments. This is what the pull request entails.I thought I should make a PR in case you want the change.
-V
argument is slightly different. It includes the file name instead of just a number like so:ERROR: color.vert:15: '' : syntax error, unexpected IDENTIFIER
Instead of:
ERROR: 0:15: '' : syntax error, unexpected IDENTIFIER
This is why the regex for the error parser was changed.