-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fee bumping channel openings #1319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hsjoberg
requested changes
Nov 1, 2023
hsjoberg
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For iOS we need to manually add the gRPC functions in Lnd.swift, otherwise BumpFee won't work.
niteshbalusu11
force-pushed
the
fee-bumping-support
branch
from
December 8, 2023 04:14
5f13b52
to
5d30a8d
Compare
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
niteshbalusu11
force-pushed
the
fee-bumping-support
branch
from
December 8, 2023 11:47
bdb103b
to
0d21131
Compare
8 tasks
hsjoberg
requested changes
Dec 14, 2023
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
hsjoberg
requested changes
Dec 15, 2023
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
Signed-off-by: Nitesh Balusu <84944042+niteshbalusu11@users.noreply.github.com>
hsjoberg
approved these changes
Dec 20, 2023
hsjoberg
changed the title
Add support for fee bumping
Add support for fee bumping channel openings
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nitesh Balusu 84944042+niteshbalusu11@users.noreply.github.com
This is still a draft PR, needs some work and on the UI side.