Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User stories 45 & 46 - Merchant enables/disables an item #124

Merged
merged 4 commits into from
May 27, 2019

Conversation

chakeresa
Copy link
Collaborator

Closes User Story 45 (#45) & 46 (#38) - Merchant enables/disables an item

  • Feature tests(%) - 98%: skipping 4 edge case tests right now because I can't figure out how to test them using Capybara! Might have to ask the instructors, or make the code in my controller actions dumber...
  • Model tests(%) - 100%
  • Commented Hard to Understand Areas? N/A

@smainar
Copy link
Collaborator

smainar commented May 27, 2019

I made all of the edits, as suggested.

Copy link
Collaborator

@smainar smainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
If a link or button initiates a request that takes a long time to respond then the user (being a user) might click the link or button again. Depending on the code implemented on the server this could put the application into a bad state.

Rails has a handy feature that will disable a link or button after the user has clicked it, "disable_with:". In Rails 5.0 and up submit buttons have disable_with set by default.

@smainar smainar merged commit 21da450 into master May 27, 2019
@chakeresa chakeresa deleted the user_stories_45_46 branch May 29, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants