-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported GHC list #58
Conversation
.github/workflows/build.yml
Outdated
@@ -16,18 +16,17 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: | |||
- ubuntu-16.04 # https://launchpad.net/~hvr/+archive/ubuntu/ghc?field.series_filter=xenial | |||
- ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI was failing because no build boxes were available for this for over a day. Trying this to see if it'll work
@sol This is a pretty big change in terms of what is being dropped, but I would be really surprised if anyone is impacted by this. There are, after all, lots of |
@parsonsmatt I think if we use |
Indeed, getting the I am curious what the point of supporting GHCs so old is. Is this a firm commitment (eg we won't incorporate features that will break for old GHC / we'll use |
@@ -16,7 +16,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: | |||
- ubuntu-16.04 # https://launchpad.net/~hvr/+archive/ubuntu/ghc?field.series_filter=xenial | |||
- ubuntu-18.04 # latest # https://launchpad.net/~hvr/+archive/ubuntu/ghc?field.series_filter=xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parsonsmatt not a big thing, but I guess we should remove the latest
from the comment. Other than that it's good to go.
@parsonsmatt please squash the commits and rebase. |
I'm willing to discuss dropping support for older GHCs at the point it provides tangible user value. |
Closing in favor of #59. |
Rational: The track record of |
This PR drops GHC < 7.10 support and adds CI for GHC 9.0 and 9.2
According to the State of Haskell 2021 Survey, fewer than 1% of respondents were using GHC < 8.2.
GHC 7.10 was released seven years ago, which is a pretty huge maintenance window.
It's difficult to even install or build things with GHCs that old. I was able to get the repo building with
stack
and--resolver lts-6
, but prior resolvers had problems withCabal
and needed olderstack
versions.ghcup
doesn't provide anything older than 7.10.3, and I wasn't even able to get that to build the library on my machine.