Optimized all resource tracker to stop tracking services that are not re... #93
Conversation
… resources.Fixed a bug with HttpTracker removedService method not being called. Fixed a bug with application not being marked dirty when removing a resource. Optimized Configuration,ServletConfiguration and ApplicationConfiguration updates to not recreate the JerseyContext but instead update the existing objects. Reworked/extended tests. Signed-off-by: IVAN GEORGIEV ILIEV <ivan.iliev@musala.com>
|
Thanks will review in a few days. We are currently in a release phase which does not allow me to spend time for this right now ;( |
|
That's ok for now we are using a locally built version of the publisher. When this makes it to a release we'll adapt :) |
| * Holger Staudacher - initial API and implementation | ||
| * ProSyst Software GmbH. - compatibility with OSGi specification 4.2 APIs | ||
| * Ivan Iliev - added ServletConfigurationTracker | ||
| * http://www.eclipse.org/legal/epl-v10.html Contributors: Holger Staudacher - initial API and |
There was a problem hiding this comment.
@kolkoo You seem to have messed up the formatting of the license headers...
|
Don't worry. I will fix them during review ;) |
|
Sorry, could not manage to integrate it so far. I'm also on vacation fro 2 weeks now. Will do it right after I return. Sorry for the delay |
|
working on it today |
|
ok let me know how it goes :) |
|
Merged with minor changes. Can you verify that the current master version works for you? |
|
Hi, yes I will check it out by the end of this week. |
|
Sorry for the delayed response, everything is looking good for us. I am now using a built version from the latest master - and have added some slf4j logging for debugging purposes to it and all is looking good. Maybe we can consider adding some logging to the connector or what is your opinion about that? |
|
Nope, no logging :). If needed users can use the Jersey tracing feature, see https://jersey.java.net/documentation/latest/user-guide.html#appendix-properties |
|
Yes, I thought so :P |
|
@hstaudacher Any plans to do a new release which includes these optimizations? |
|
Yes, I jus tneed to upgrade to Jersey 2.18. Probably next week I will find some time |
...sources.Fixed a bug with HttpTracker removedService method not being called. Fixed a bug with application not being marked dirty when removing a resource.
Optimized Configuration,ServletConfiguration and ApplicationConfiguration updates to not recreate the JerseyContext but instead update the existing objects. Reworked/extended tests.
Signed-off-by: IVAN GEORGIEV ILIEV ivan.iliev@musala.com