[BUG] Wrong error message for variable left uninitialized

[JohelEGP]

Title: Wrong error message for variable left uninitialized.

Description:

This change might have to do with commit 797569a.
There need to be regression tests for all of cppfront's diagnostics.

Minimal reproducer (https://cpp2.godbolt.org/z/MzqbWKzM9):

main: () = {
  x: int;
}

Commands:

cppfront main.cpp2
clang++18 -std=c++23 -stdlib=libc++ -lc++abi -pedantic-errors -Wall -Wextra -Wconversion -Werror=unused-result -Werror=unused-value -Werror=unused-parameter -Werror=unused-variable -I . main.cpp

Expected result: A diagnostic about x never being initialized.

Actual result and error:

Output:

main.cpp2...
main.cpp2(2,3): error: local variable x is used before it was initialized
  ==> program violates initialization safety guarantee - see previous errors

[JohelEGP]

Also, what happened to cppfront's unused variable diagnostic?
I remember that being a thing, though I may be wrong.
See https://cpp2.godbolt.org/z/6n63hzzo3, which is rejected by the Cpp1 compiler via -Werror,-Wunused-variable.

[JohelEGP]

Also, what happened to cppfront's unused variable diagnostic?

This check was added in 243d03d
-- #832 (comment)

Did I maybe undo it with #887?