[BUG] No way to declare std::function that use references in cpp2

[filipsajdak]

In the current implementation of cppfront (5fa2707) in cpp2, there is no way to declare std::function that uses references.

The following examples failed to work:

f1: () -> std::function<std:string(std::string const&)> = { // error: missing = before function body (at '<')
    return :(s : std::string) -> std::string = {
        return s + " World!";
    };
}

f2: () -> std::function<(std::string) -> std::string> = { // error: missing = before function body (at '<')
    return :(s : std::string) -> std::string = {
        return s + " World!";
    };
}

f3: () -> std::function<std::string(std::string)> = {
    return :(s : std::string) -> std::string = {
        return s + " World!";
    };
}

The last example passes cppfront, but generates different types of arguments:

[[nodiscard]] auto f3() -> std::function<std::string(std::string)>{
    return [](cpp2::in<std::string> s) -> std::string{
        return s + " World!"; 
    }; 
}

I have also tried the code that was presented on the wiki (https://github.com/hsutter/cppfront/wiki/Design-note%3A-Postfix-operators#-and-)

f: (i:int) -> * (:int) -> string = {
    return :(j:int) -> std::string = {
        return std::to_string(j);
    };
}

but it also failed:

bug_std_function.cpp2(1,17): error: '*'/'const' type qualifiers must be followed by a type name or '_' wildcard (at '(')
bug_std_function.cpp2(1,19): error: missing function return after -> (at 'int')

I would like to be able use cpp2 function types as templates arguments, or function argument and return types.

From what I understand from the wiki my code should be written in the following way:

f: () -> std::function<(:std::string) -> std::string> = {
    return :(s : std::string) -> std::string = {
        return s + " World!";
    };
}

[JohelEGP]

Seems like there are no unnamed parameters: https://godbolt.org/z/zG7xGh3Kz.

f: (:int) = { }

main.cpp2(2,10): error: invalid parameter list (at ':')
main.cpp2(2,14): error: ill-formed initializer (at ')')
main.cpp2(1,12): error: ill-formed initializer (at '{')
main.cpp2(1,1): error: unexpected text at end of Cpp2 code section (at 'main')
main.cpp2(1,0): error: parse failed for section starting here

Some test cases: https://godbolt.org/z/oxrhsecdq.

main: (args) = {
  a: * int;
  a = args.argc;

  b: * ();
  b = :() = { };

  c: * (_: int);
  c = :(_) = { };

  d: * (_: int) -> int;
  d = :(x) -> _ = x;

  e: * (_: * ());
  e = :(x) -> _ = x;
}

[orent]

While I generally agree with the elimination of references in favor of in/out/inout arguments there should still be a way to spell them because they remain a part of the underlying object model - just doesn’t have to be particularly short.

How about std::reference or something similar?

[JohelEGP]

I agree. I don't think you can rewrite this in pure Cpp2: https://godbolt.org/z/csKcPTrzx.

using Int = const int&;

min: (l: Int, r: Int) -> Int = {
  if l < r {
    return l;
  } else {
    return r;
  }
}

main: () = {
  x := 0;
  y := 1;
  [[assert: min(x, y)& == x& ]]
}

[filipsajdak]

@JohelEGP not the same but works: https://godbolt.org/z/zKnn7re3d

min: (forward l: int, forward r: int) -> forward int = {
  if l < r {
    return l;
  } else {
    return r;
  }
}

main: () = {
  x := 0;
  y := 1;
  [[assert: min(x, y)& == x& ]]
  y++; // this is needed to supress move from last use
}

[leejy12]

@filipsajdak But that min implementation won't work when passing rvalues.

[filipsajdak]

@leejy12 in that specific use case, it is a feature. You don't want to check an address to a temporary variable.

[leejy12]

@filipsajdak True, but I'm still looking for a way to correctly implement std::min in pure Cpp2.
I think this comment by @AbhinavK00 is the correct analysis.

Why in parameters? The above examples make perfect sense if we function takes something with size more than 2 pointers (I think it is any UDT now).

I think the right diagnosis isn't to ban forward return of in arguments but to pass the argument by reference everytime the function forward returns it. How would we write functions such as std::min etc. with this?

When we're forward returning an in parameter, it should be passed as const T& not cpp2::in<T>.

So Cpp2's implementation of std::min could look like

min: <T> (a: T, b: T) -> forward _ = {
    if a < b {
        return a;
    }
    else {
        return b;
    }
}

which will be compiled to

template <typename T>
auto min(const T& a, const T& b) -> auto&& {
    if (a < b) {
        return a;
    }
    else {
        return b;
    }
}

This is pretty much what I already wrote in #248 (comment). What do you think?

[JohelEGP]

Remember that the min of #343 (comment) is not a template. Although this may be similar to #193 (comment). How often do you write a non-templated function whose result is a read-only argument (so identity matters), that in parameter passing would optimize to pass by value (so it may not be future-proof or portable)?

[AbhinavK00]

How often do you write a non-templated function whose result is a read-only argument

The current design doesn't even allow us to write function templates that return an in argument.
Edit: Issue #317 which restores old behaviour of cpp2::in can also proceed with a check of whether the argument is being forward returned and then just pass it by const&.

[JohelEGP]

The current design doesn't even allow us to write function templates that return an in argument.

I don't understand. Can you give an example?

[AbhinavK00]

From a comment in this issue only, the following isn't allowed in cpp2

min: <T> (a: T, b: T) -> forward _ = {
    if a < b {
        return a;
    }
    else {
        return b;
    }
}

[AbhinavK00]

From a comment in this issue only, the following isn't allowed in cpp2

min: <T> (a: T, b: T) -> forward _ = {
    if a < b {
        return a;
    }
    else {
        return b;
    }
}

[JohelEGP]

You're right: https://godbolt.org/z/MaWdqG1dM.

I changed -> forward _ to -> forward T, honest to the signature of std::min.
Then I tried adding parentheses around the returned parameters. cppfront then accepts: https://godbolt.org/z/1M9asnh1c.
The generated code returns T&.

Changing back to -> forward _ makes the declared return type be auto&&, which results in working code: https://godbolt.org/z/rra8EW8z1.

Knowing that a declared return type of auto&& or decltype(auto), and redundant parentheses, can change meaning from "type and value category of the expression" to "declared type of the data member in the data member access expression" (see this "1)" and this "2)"), I next tried with a type: https://godbolt.org/z/Kszo8EPfc.
Looks like not using T directly as the parameter's type results in cppfront wrapping the declared parameter type in cpp2::in, which results in a parameter type that can't be deduced from its argument. That's #367.

main.cpp2:10:41: note: candidate template ignored: couldn't infer template argument 'T'
template<typename T> [[nodiscard]] auto min(cpp2::in<range<T>> r) -> auto&&{
                                        ^