Fix: int variable casted with as to size_t does not fail on compile time - closes #1257
#1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmarr
reviewed
Aug 23, 2024
DyXel
reviewed
Aug 23, 2024
DyXel
reviewed
Aug 23, 2024
filipsajdak
force-pushed
the
fsajdak-fix-is-narrowing
branch
from
83563ac to
2642c2b
Compare
The current implementation of `is_narrowing_v` does not handle type conversions correctly. For example, `cpp2::impl::is_narrowing_v<std::size_t, int>` returns `false`, indicating that it mistakenly perceives the conversion from a signed `int` to an unsigned `size_t` as potentially non-narrowing. Closes hsutter#1257
filipsajdak
force-pushed
the
fsajdak-fix-is-narrowing
branch
from
2642c2b to
426dd8e
Compare
|
Thanks! Looks good except for the conflicts -- can you take a pass through to resolve those? Then this should be ready to merge, thanks again. |
hsutter
added
question - further information requested
|
@gregmarr No, thanks for the reminder! |
|
Re #1257: Thanks for the discussion! I'm going to stick with status quo on this for now, but please feel free to reopen if over time you find this keeps causing problems or user surprise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
is_narrowing_vdoes not handle type conversions correctly. For example,cpp2::impl::is_narrowing_v<std::size_t, int>returnsfalse, indicating that it mistakenly perceives the conversion from a signedintto an unsignedsize_tas potentially non-narrowing.The new implementation is based on curly braces initialization on the cpp1 side which does all the required checking correctly. Examples here: https://godbolt.org/z/EdEK75E7z
Closes #1257