Make cpp2::args usable as a std::ranges::bidirectional_range #1281
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to cppfront. I've emailed you the Contributor License Agreement (CLA), and once it's signed I can look at your pull request. Thanks again for your contribution. |
jhugard
force-pushed
the
range-compatible-main-args
branch
from
be19dc9 to
759493c
Compare
include/cpp2util.h
Outdated
| constexpr iterator(const iterator& o) = default; | ||
| constexpr iterator(iterator&& o) = default; | ||
| constexpr iterator& operator=(const iterator& o) = default; | ||
| constexpr iterator& operator=(iterator&& o) = default; |
There was a problem hiding this comment.
Did it not work without explicitly defaulting the copy/move functions?
There was a problem hiding this comment.
No, it does not. Apologies for patronizing, but because a constructor (with parameters) was specified, the default ctors and assignment are suppressed.
Rule-of-zero, rule-of-five says if you define one, you should define them all: see core guidelines C.ctor C.21.
There was a problem hiding this comment.
Defining any constructor suppresses the default constructor, which is why you need a version with =default for that.
However, the default constructor is not part of the rule of 0/5 from C.21. Those are copy/move construct/assign, and destructor. They should all still be generated unless you define one of those 5.
https://en.cppreference.com/w/cpp/language/copy_constructor
If no user-defined copy constructors are provided for a class type, the compiler will always declare a copy constructor as a non-explicit inline public member of its class.
Here's a table form of that information: https://mariusbancila.ro/blog/2018/07/26/cpp-special-member-function-rules/
There was a problem hiding this comment.
TIL, thank you! I stand 100% corrected and have apparently misunderstood the rule of five for some time: I had been including the default constructor in that count, rather than the dtor. Appreciate your link to the table form. Very clear.
There was a problem hiding this comment.
TIL, thank you!
You're welcome.
I had been including the default constructor in that count, rather than the dtor.
That's an easy mistake to make. I'm pretty sure I've included it in the past. :)
|
@jhugard Did you return the CLA? |
I am still waiting for approval from our legal department, which could take a while. |
Ugh, I feel your pain. :) |
Satisfy the
std::ranges::bidirectional_rangeconstraint, so thatcpp2::argscan be used withstd::rangesadapters, etc.See #1280.