Fix string literal parsing when \\ is on the end, closes #301 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that when there is '\\' on the end of the string `expand_string_literal()` function goes out of string range because for loop has a check ```cpp pos < length && (text[pos] != '"' || text[pos-1] == '\\') ``` that is true when '\\' is before last '"' character that cause loop to go beyond it and cause assertion to fail. The current change adds a check if the '\' character before last '"' is not escaped by the former '\' character.
|
Looks good, thanks! |
|
I start to become a cppfront string specialist 😉 |
|
At this point you've probably written as much of the string literal handling as I have, maybe more. 😁 🙏 |
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
The issue is that when there is '\\' on the end of the string `expand_string_literal()` function goes out of string range because for loop has a check ```cpp pos < length && (text[pos] != '"' || text[pos-1] == '\\') ``` that is true when '\\' is before last '"' character that cause loop to go beyond it and cause assertion to fail. The current change adds a check if the '\' character before last '"' is not escaped by the former '\' character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that when there is '\' on the end of the string
expand_string_literal()function goes out of string range because for loop has a checkthat is true when '\' is before last '"' character that cause loop to go beyond it and cause assertion to fail.
The current change adds a check if the '' character before last '"' is not escaped by the former '' character.
Closes #301 - all regression tests pass