Fix unpublished comments ICE error #351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parsing of the following code:
```cpp
a: type = { } // a
i : int = 42;
```
The current implementation fail with ICE. After this change works and generate correct code.
Only one test change behaviour (due to lack of new line on the end of class definition):
```patch
diff --git a/regression-tests/test-results/pure2-types-order-independence-and-nesting.cpp b/regression-tests/test-results/pure2-types-order-independence-and-nesting.cpp
index 9449c2a..5ace9c1 100644
--- a/regression-tests/test-results/pure2-types-order-independence-and-nesting.cpp
+++ b/regression-tests/test-results/pure2-types-order-independence-and-nesting.cpp
@@ -69,8 +69,8 @@ namespace M {
template<typename T, typename U> class A {
public: template<int I> class B {
public: template<typename V, int J, typename W> static auto f(W const& w) -> void;
-public: B() = default; B(B const&) = delete; auto operator=(B const&) -> void = delete; };
-public: A() = default; A(A const&) = delete; auto operator=(A const&) -> void = delete; };
+public: B() = default; B(B const&) = delete; auto operator=(B const&) -> void = delete; };public: A() = default; A(A const&) = delete; auto operator=(A const&) -> void = delete;
+};
}
```
The current implementation of cppfront ends with ICE
when parsing the following code:
```cpp
a: namespace = { } // a
i : int = 42;
```
After this change code is parsed and cppfront generates correct code.
Contributor
|
Thank you. I still get it on this: Still ICEsThe last line suffices for the ICE: |
Contributor
Author
|
@JohelEGP yes, I have noticed that. I am looking for a fix. |
filipsajdak
changed the title
Contributor
Author
|
#344 is not fixed by this PR (I fixed two other issues) - more description about the original issue here: #344 (comment) |
Owner
|
Thanks! BTW I made that comment check such a noisy ICE because it's super important to me to never drop anything the programmer wrote, including (or even especially?) comments. Thanks for looking into this. |
Owner
|
Thanks for the bug reports and repros! These should all work now, fixed as a separate commit (see commit message), please check... and I did take the part of the suggested PRs which was to do the extra finalizing at the end of each section (not just at the very end of the file). 🙏 |
Contributor
Author
|
Checking... |
Contributor
Author
|
I confirm that it works on my tests as well. |
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
…loses hsutter#351, closes hsutter#354 Thanks for these test cases. The common issue was that occasionally an emitted piece of Cpp1 contained a newline character, which was not accounted for in the code that did comment merging. Thanks also for the PRs for proposed fixes. I looked at those too and tried them out. In the end, I found that what worked best and most generally was to break apart strings that contain newlines into one chunk per line, and this allowed the comment merging to happen correctly by avoiding the hidden-to-the-comment-merger line change. So this commit is going with that solution rather than the other proposed PRs, but the other PRs helped find this root cause and shed light on a general solution, as did the test cases. Thanks again for both!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of cppfront (f83ca9b), the following code:
a: type = { } // a i : int = 42;or
End with ICE
not all comments were printederror.This change removes extra new-line printed after namespace or UDT definition that solves this issue.
All regression tests pass (except for two files impacted by missing newlines - updated in this PR).