Add diagnostics for type alias to a wildcard, closes #357 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsajdak
force-pushed
the
fsajdak-add-diagnostics-for-alias-with-wildcard
branch
from
41051bd to
f50639e
Compare
In the current implementation of cppfront (f83ca9) the following code: ```cpp alias5: type == _; alias6: type == auto; ``` Generates succesfuly: ```cpp using alias5 = auto; using alias6 = auto; ``` Which is invalid cpp1 code. After this change the alias to wildcard will generate the following error: ``` error: a 'type ==' alias declaration must be followed by a type name (not a wildcard _ nor auto) ``` All regression tests pass. Closes hsutter#357
filipsajdak
force-pushed
the
fsajdak-add-diagnostics-for-alias-with-wildcard
branch
from
f50639e to
6de944b
Compare
|
Thanks! |
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
…tter#360) In the current implementation of cppfront (f83ca9) the following code: ```cpp alias5: type == _; alias6: type == auto; ``` Generates succesfuly: ```cpp using alias5 = auto; using alias6 = auto; ``` Which is invalid cpp1 code. After this change the alias to wildcard will generate the following error: ``` error: a 'type ==' alias declaration must be followed by a type name (not a wildcard _ nor auto) ``` All regression tests pass. Closes hsutter#357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of cppfront (f83ca9), the following code:
alias5: type == _; alias6: type == auto;Generates succesfuly:
Which is an invalid cpp1 code.
After this change, the alias to wildcard will generate the following error:
All regression tests pass. Closes #357