feat: accept type arguments in function calls #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
commented
Jan 8, 2024
|
From #628:
Can you elaborate with examples where this is used? I'm not seeing the use cases in the PR code shown so far, unless the answer to my first question about |
hsutter
reviewed
Jan 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
hsutter
added
question - further information requested
|
Thanks! Sorry for the lag -- in the meantime I've added some support for function types so this PR would need to be rebased to align with and extend that. Which would be your preference: Do you want to rebase this, or close this for now? |
JohelEGP
force-pushed
the
function_type_argument
branch
from
1a260f7 to
f6c399d
Compare
JohelEGP
changed the title
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #628 (comment).