Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(to_cpp1): direct-initialize statement parameter and constexpr variable #924

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Jan 9, 2024

Resolves #699. Resolves #801.
Resolves #527.

@hsutter
Copy link
Owner

hsutter commented Jan 9, 2024

Thanks! I see this also fixes another annoyance that I hadn't yet got around to fixing, which was initializing something like a vector in a statement parameter list:

(v: std::vector<int> = (1,2,3))   // miscompiles today, works with this PR
for v do (e) std::cout << e;

@hsutter hsutter merged commit 7fff368 into hsutter:main Jan 9, 2024
@JohelEGP JohelEGP deleted the cpp2_init_is_cpp1_direct_init branch January 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants