Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC regression-test job in CI now builds and links with C++ standard library modules to enable import std.compat; #953

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

bluetarpmedia
Copy link
Contributor

  • Re-enable the -import-std / pure behaviour
  • The CI build script now compiles the std and std.compat modules and links the std.obj and std.compat.obj files when building the regression test binaries.

See #950 for more details.

@hsutter hsutter merged commit 0e74bd7 into hsutter:main Jan 22, 2024
15 checks passed
@hsutter
Copy link
Owner

hsutter commented Jan 22, 2024

Thanks! I guess rebuilding the four std* files once per regression test run is not too bad, it seems to take about as long as running a handful of test cases. That's reasonable.

@bluetarpmedia
Copy link
Contributor Author

Thanks! I guess rebuilding the four std* files once per regression test run is not too bad, it seems to take about as long as running a handful of test cases. That's reasonable.

Yes, that's what I was thinking -- I should've mentioned that sorry.

It means we won't run into problems if the compiler flags need to change, or if a Visual Studio update on the GitHub-hosted runner affects the ifc or obj files.

@bluetarpmedia bluetarpmedia deleted the ci-msvc-enable-modules branch January 22, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants