Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebrand for Hightouch Events Go SDK #1

Merged
merged 15 commits into from
Mar 12, 2024
Merged

Rebrand for Hightouch Events Go SDK #1

merged 15 commits into from
Mar 12, 2024

Conversation

narciero
Copy link
Contributor

@narciero narciero commented Mar 1, 2024 •
edited
Loading

Refactor of Go SDK for Hightouch Events.

@narciero narciero requested a review from NickStefan March 11, 2024 21:07
NickStefan
NickStefan reviewed Mar 12, 2024
View reviewed changes
Copy link

@NickStefan NickStefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. My comments are mostly about documentation (Readme and doc strings). We should fix them before merging.

Readme.md Outdated Show resolved Hide resolved
alias.go Show resolved Hide resolved
context.go Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
@narciero narciero requested a review from NickStefan March 12, 2024 20:51
@narciero narciero changed the title Rebrand Rebrand for Hightouch Events Go SDK Mar 12, 2024
@narciero narciero merged commit 5c6da58 into main Mar 12, 2024
3 checks passed
@narciero narciero deleted the narciero/rebrand branch March 12, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickStefan NickStefan NickStefan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narciero @NickStefan