Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilanguage next i18next #41

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Conversation

romros
Copy link

@romros romros commented Aug 12, 2023

Hello Tuan Anh,

My name is Roman Roset from Barcelona, and I am a programmer. I wanted to create my web profile using Next.js and React, and after coming across your work, I was truly impressed and felt inspired to use it. To express my gratitude for your hard work and to give back instead of just using your code, I've added multilanguage support using next-i18next. I've set it up with three languages as an example, which are also the ones I intend to use for my profile. Additionally, I hope you don't mind, but I've added a Table of Contents (ToC) in the Resume section.

I deeply appreciate all the effort you've put into your project. Please let me know if you believe any part of the translation can be improved or if you have any suggestions. Thank you very much!

Best regards,
Roman Roset

@vercel
Copy link

vercel bot commented Aug 12, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @hta218 on Vercel.

@hta218 first needs to authorize it.

@romros
Copy link
Author

romros commented Aug 12, 2023

By the way...you can view the results here: https://leohuynh-dev-multilanguage-lcdkadsvr-romros.vercel.app/es/

@hta218 hta218 self-requested a review August 13, 2023 01:55
@hta218 hta218 added the enhancement New feature or request label Aug 13, 2023
@hta218
Copy link
Owner

hta218 commented Aug 13, 2023

Wow, Roman!

Thank you so much for your contribution to my project! I'm so glad you found it useful as inspiration for your own website. Adding multi-language support and the ToC are awesome additions that will make the project even more valuable to others.
I really appreciate you taking the time to give back instead of just using the code.

The translations look great at first glance. I will take a closer look and let you know if I spot anything that could be improved.
This PR will definitely be merged soon!

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leo-huynh-dot-dev ❌ Failed (Inspect) Aug 13, 2023 4:05am

@hta218 hta218 merged commit ce6c9a5 into hta218:main Aug 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants