Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Make the bash scripts path-agnostic #18

Merged
merged 1 commit into from
May 6, 2017
Merged

Conversation

lhchavez
Copy link
Contributor

@lhchavez lhchavez commented May 6, 2017

This change updates the bash scripts so that they can be invoked from an
arbitrary path. It also tries to be consistent of using braced, quoted
variables.

This is needed to fix htacg/tidy-html5#545

This change updates the bash scripts so that they can be invoked from an
arbitrary path. It also tries to be consistent of using braced, quoted
variables.
@balthisar balthisar merged commit b1595d9 into htacg:next May 6, 2017
@lhchavez lhchavez deleted the travis branch May 6, 2017 23:15
@balthisar
Copy link
Member

@lhchavez, I had to undo this merge. When testing on a non-GNU versions of readlink, there's no -e option, and so the tools fail. I'll try to go back and cherry pick the other changes, e.g., the consistency with the quotes.

I'll miss the path independency, though. If you implement something without readlink, I'll be happy to merge that back in, too.

@lhchavez
Copy link
Contributor Author

is this something reproducible on osx? i can try to get my hands on one and give it a try.

@balthisar
Copy link
Member

Yes, and BSD.

@lhchavez
Copy link
Contributor Author

thanks, and sorry about the breakage.

@balthisar
Copy link
Member

No big deal. Usually macOS is the first platform I test on, so my bad for accepting it in Ubuntu only.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Continuous Integration
2 participants