-
Notifications
You must be signed in to change notification settings - Fork 429
Pushing for full HTML5 support #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also another broken post... Best regards, |
Hello Geoff – Just came across your tidy-fork repo and saw that yours is more frequently updated than w3c/tidy-html5. Can you please tell us what’s new in your version and if you plan to document your changes. Is it possible to merge these changes back here? Thank you. IR |
Hi Ionel, What a pleasure to get your email ;=)) It seemed no one was interested
First I swung over the a cmake build which supports cross platform I now have quite a LOT of experience with cmake, and even have a Second, I gathered as much information from the W3C site, particularly, Then added about a dozen pairs of html to test elements removed in 5 -
to do... Then back to the original nearly 250 'test/input' files, to try to check Here I started to run out of steam ;=(( With no one to discuss with,
That was always intended, but I do not have commit rights to The Questions: My main concern is how to keep HTML4 and earlier support, while still Of course one course of action would be to separate the library into to In testing I have been using doctype: html5 to tell tidy to go HTML5 (a) has the HTML5 doctype And maybe such a determination that this IS html5 could trigger some So here we are... I would be willing to put in some more time on tidy, Regards, |
Geoff Thanks so much for the quick response and the insights. While there are other libraries and tools for checking and cleaning up HTML, tidy-html5 is definitely the most reputable and it should be maintained, one way or another, but preferably under W3C. As of today (Sept 4, 2014) there are 59 open tickets, 12 pull requests and ... zero commits since Aug 21, 2012. At this point there are two options: re-engage developers with commit access, or fork the repo and continue development. What do you, or others, think? Thanks. Ionel Ionel |
On Sep 4, 2014, at 2:00 PM, Ionel Roiban notifications@github.com wrote:
Who would be doing the "continue development"? It seems to me that the problem isn't the repo or the project but that we don't have developers with the time/motivation/etc to work on it. If there are developers who are ready to do development on the project, then I wonder what they think next steps should be. You say "re-engage developers with commit access", which sounds like you're saying that more people would work on the project if they had commit access. Is that the case? Who are these developers that are being stymied by lack of commit access? Andy Lester => www.petdance.com |
I would strongly suggest that people who are willing to work on this fork this repo into a HTML5Tidy organization here on GitHub - or that @sideshowbarker donate the project to such an organization. Then, developers who are willing to maintain the project can better organize, review code, etc. |
Do you actually have "developers who are willing to maintain the project"? I don't think forking the project is going to make developers appear. Don't get me wrong: I'd LOVE to have some forward direction on the project, and I'd contribute, but mostly it needs strong direction. |
The only problem with a fork is that it will lose the reputation that the W3C organization provides to such an important project. Prior to forking and moving development elsewhere due diligence should take place here, in order to get W3C to acknowledge the situation. |
@skynet, that's a good point - but I don't think we can depend on the W3C on its own here. This is really just @sideshowbarker's pet project and not a W3C thing (i.e., they don't provide funding or support in any way). Clearly, @sideshowbarker doesn't have time to do any work on this (as he has stated in other bugs). I'll wait for him to decide what to do. I've spoken to him in the past about opening it up, but he hasn't yet found anyone that he trusts in the community to take the project over. I don't see what option there is but to open it up to a few people who have shown, through PRs, capable of reviewing and maintaining the code. Maybe we can get a show of interest from people who could commit time to this? |
A better documentation Website could also help with making the project self-sustainable, increase traffic and adoption. http://w3c.github.io/tidy-html5/ is not enough for that purpose. |
Hi skynet, petdance, marcoscaceres, Good to read and 'feel' some interest ;=)). 1: Where should this discussion take place?I do not think issues #122 here is the right place! I would whole heartedly suggest tidy-dev/sorceforge (a) involve the current maintainer there, arnaud02, (b) get an email when something is posted. I can/will not check back at #122 all the time! Ionel has been kind enough to cc's me otherwise Except for me, admittedly not much has been happening I will try to cross post this reply... and include 2: who can put in coding timeTo repeat, I can, but to also repeat, I can/will not I have been contributing code fixes since around 2000, But I need others to be testing, commenting, contributing, Ionel, you mentioned there are 59 open tickets, and 12 Well, I would look at these if - (a) html-tidy5 is updated to where my tidy-fork is at, (b) pull requests can only be merged by those with write 3: which repoDo not really care, but would certainly these days (a) sideshowbarker was new to me, and still to explore (b) tidy-html5 - yes, subject to 2:(a) and (b) above. (c) original sourceforge svn. Possibly, but only if (d) My tidy-fork. Well this is where I will continue for Others??? 4: Discussion on some of the conflicts between 4 and 5As expressed, if the one 'library' is to do BOTH at This is my current stalling point, and seek ideas... Regards, |
Geoff - We shall continue the due diligence for contacting and getting W3C to acknowledge the situation but instead of waiting I would just fork and move on - I am sure there are a lot of developers waiting to contribute and help with testing. Thanks for yours and other's interest in reviving this project. Ionel |
Hi Ionel, Yes, as you suggest am moving on with I just did a push to always show the And in fact have accepted my first Especially treating - See here - Do you know what is the W3C position on I note they have a tutorial on it in All for a better tidy... Regards, |
Glad to hear about your progress! Just because they are named W3Schools does not mean they are associated in any way with W3C. Moreover their site is far from being a trustworthy reference source. It is a site built for SEO. AngularJS is a Google project. My first guess is that, instead of micro-managing third-party attributes, you should make it possible for anyone to add custom attributes to the list of valid items. Cheers! |
Any news about this? |
Hi Ionel, While most of the AnuglarJS stuff was At this point my tidy5 fork does everything I The last effort was a few weeks ago just to Regards, On 16/12/14 16:57, Ionel Roiban wrote:
|
Sounds good, thanks! |
@geoffmcl, I can't do a PR to your fork, but perhaps you'll take a look at this: It's your fork as ca. November, with several of the PR's in this branch manually merged in, primarily support for all of the vast array of attributes (plus my own PR for a secondary messages callback filter that I need for language localization). Because so many of the existing PRs are based on the master branch, there were tons and tons of conflicts I had to handle manually. It's a shame this branch isn't maintained, but as far as I can tell from activity, your fork is a lot more canonical than mine, and it would be good to have many of these PR's merged into a fork with visibility. |
Hi balthisar, Sorry for the delayed reply but still busy with Wow, it is great to read LOTS of 'tidy' activity ;=)) Yes, after forking and adding what I wanted I did NOT As soon as I get a chance I will look at your - Now also watching htacg/tidy-html5... And joined the HTML Tidy Advocacy Community Group right Anyway, great to read lots... be back soonest... obviously Regards, |
Geoff, we all understand time commitments! I'm hopeful that we won't let get things to backlogged anymore. We're still trying to figure out a proper strategy for the outstanding PRs. Have you run through the regression tests with my fork? It's on my very long to-do list. Given that it includes a good number of the PR's, it would be convenient if we could verify its trustworthiness. (Note, have to remove my private project branding, though!). |
Hi Jim, My other projects have quietened down so found
One item needed was to add a va_copy(a,b) to #ifndef va_copy
(i) The biggest one was src/attrdict.c - not You had carefully moved every existing definition On carefully checking this was NOT true, and (ii) The only other conflicts were all in the I have decided to go 100% CMake since it generates And fixed the README.md and README.html to match... When I deleted all these same things in your
And did a compile check in my Ubuntu 14.04 linux...
The most difficult is one concerning treating But have a good trace on this, and should be Also picked up one issue from htacg/tidy-html5 For <script src="..." async>, change CH_PCDATA Started to look at some others... there are 64... And looking at the 14 PRs, but most of which would
I certainly agree this is becoming IMPORTANT ;=() To me it is important that tidy5 can do ALL that I have had it as a note to myself, as Issue #1, Will certainly try to deal with that during this
(a) At this time htacg/tidy-html5 now seems so far (b) I could easily bring your balthisar/tidy-html5 up Of course until I see a direction emerging I will What is your idea? Regards, |
@geoffmcl, direction should be coming soon. Don't despair again. |
So have pushed develop-500 branch to this repo, and would really appreciate any testing and reviewing of this branch. $ git checkout develop-500 This should make my tidy-fork redundant... Will try to add the infrastructure label to this, since it contains a lot of discussion... and have also posted a message to - And hope any, all of you can help testing this latest... Thanks... |
👍 |
I will close this issue as "overly broad." :-) |
Removed this rather broken orignal post, but still 'Pushing for full HTML5 support.
Regards,
Geoff.
The text was updated successfully, but these errors were encountered: