Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<img> proprietary attribute "loading" #879

Closed
JoyceBabu opened this issue May 17, 2020 · 5 comments · Fixed by #902
Closed

<img> proprietary attribute "loading" #879

JoyceBabu opened this issue May 17, 2020 · 5 comments · Fixed by #902

Comments

@JoyceBabu
Copy link

Native lazyloading is now accepted as part of the HTML standard.

Please support it in tidy.

Is it possible to suppress these warning until it is added to tidy? Maybe create a custom DTD for tidy to validate against?

@geoffmcl
Copy link
Contributor

@JoyceBabu, I presume you are talking about <img loading="lazy" src="...">... if not please explain...

And it would be nice to add a small sample...

Native lazyloading is now accepted as part of the HTML standard.

Says who? Need some W3C references for this, links, etc... it is not just about browser support...

Is it possible to suppress these warning until ...

No. Supported attributes of each HTML tag is hard-coded into libTidy... see src const AttrVersion TY_(W3CAttrsFor_IMG)[] = ... would need to add something like a TidyAttr_LOADING... etc...

Given that you can find the W3C spec, when this would be considered a feature request...

Look forward to feedback, discussion, links, samples, patches, PR, etc... thanks...

@JoyceBabu
Copy link
Author

@JoyceBabu, I presume you are talking about <img loading="lazy" src="...">... if not please explain...

And it would be nice to add a small sample...

Yes, loading="lazy" is what I meant. Sorry for not being explicit.

Native lazyloading is now accepted as part of the HTML standard.

Says who? Need some W3C references for this, links, etc... it is not just about browser support...

Native lazy loading was merged into WHATWG/html on February 12

whatwg/html#3752 (comment)

Is it possible to suppress these warning until ...

No. Supported attributes of each HTML tag is hard-coded into libTidy... see src const AttrVersion TY_(W3CAttrsFor_IMG)[] = ... would need to add something like a TidyAttr_LOADING... etc...

Given that you can find the W3C spec, when this would be considered a feature request...

It was merged into WHATWG spec, not W3C spec. Is that not acceptable for HTACG?

Look forward to feedback, discussion, links, samples, patches, PR, etc... thanks...

@geoffmcl
Copy link
Contributor

@sidvishnoi, thank you for the WHATWG links...

@JoyceBabu, yes, I do think at this time WHATWG is acceptable to HTACG... you can read around about the agreements between the WHATWG and W3C, and it is interesting to note that they share the same validator - https://whatwg.org/validator/ directly links to https://validator.w3.org/nu/ ...

Accordingly, marking this as a Feature Request... thanks...

Look forward to samples, patches, PR, etc, to implement this... thanks...

@sidvishnoi
Copy link
Contributor

Also, https://www.w3.org/TR/html/ (which is the latest version as per https://www.w3.org/TR/html52/) redirects to the WHATWG spec.

geoffmcl pushed a commit that referenced this issue Nov 21, 2020
geoffmcl added a commit that referenced this issue Nov 21, 2020
geoffmcl added a commit that referenced this issue Nov 24, 2020
Error made when merging LOADING Is. #879, PR #902

And merging SLOT PR #848

Also added a BIG warning over attribute_defs table to try to avoid this
in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants