Sprtf #626
Merged
Sprtf #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without support for ISO2022 natively. Of course, we've been doing this by default for years with no ill effect, and all modern operating systems seem to support this natively. It's probably best to keep this in here, unlike the other deletions.
…ported platforms.
|
Doesn't break Windows, and works a treat on macOS, so in it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #624, due to the amount of merge conflicts otherwise. Builds and acts as expected on macOS, Windows 10, Ubuntu.
@geoffmcl, playing with this is a lot nicer than stepping through the code in a painstaking matter! I'm glad that it's basically already compatible with Unix.