delay calling AdjustConfig #779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling AdjustConfig Calling AdjustConfig right after reading an init file tends to break things since tidy might not have the all of the config settings yet. It needs to wait until all the init files and parameters have been processed so that it can make it's adjustments based on the full config.
|
@ler762 closing this... do not agree with the need to wait - Why? nor with can break things - What things? Please explain if you think this should go further, hopefully in an issue that addresses these things ;=)) and not in a PR! But also assume you only used it to show some code, but would always prefer that be attached, or inline patches, in the comment... thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until after reading all the init files and parameters before calling AdjustConfig
Calling AdjustConfig right after reading an init file can break things since
tidy might not have the all of the config settings yet. It needs to wait until
all the init files and parameters have been processed so that it can make it's
adjustments based on the full config.
ref: #778