-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readthedocs.yml
#59
Conversation
How do I build the docs for the branch? Never done this before... |
@lukashergt I gave readthedocs permission to build PRs and refreshed the webhook but not seeing the build here. I can add you as a maintainer on the docs? What's your readthedocs username? |
The builds can be viewed here:
Same as my GitHub username: lukashergt |
Nice, looks like this PR does indeed fix the previously failing docs: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 5 5
Lines 580 580
=======================================
Hits 478 478
Misses 102 102 ☔ View full report in Codecov by Sentry. |
The failed python 3.9 test should be unrelated to this PR. That test also fails on the master branch. |
Ahh maybe it needed a commit to trigger the build. Thanks for the help with the docs Lukas this is great. Go ahead and merge.
Hmm there is a known issue with the tests that needs fixing (just haven't got to it yet). This is new though... looks like tensorflow was updated in the last few weeks and its broken something... You're right though that this is not related to this PR so go ahead and merge. Thanks again! |
The docs on readthedocs are currently failing. I suspect this has to do with the missing
build
block specifying what OS to use. Let's see whether this fixes it.@htjb, could you tell readthedocs to build this branch, please? (alternatively give me the power and I'll fiddle around)