-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On really big files (60MB) the browser stalls #56
Comments
I am not sure which option is the best. I am leaning towards the windowing option. We can post an alert stating that the data is being windowed, and allow the user to turn that off, and load the entire file if they really want to try that - knowing that it might crash the browser. What option do you think users would prefer? |
@breznak - we can automatically use windowing on files over a certain size. I am going to arbitrarily set this to 5MB. |
…ey are local or remote.
Addresses #56. Large files will be windowed - whether they are local or remote.
Fixed with #64 , large files use 5MB size window |
As @jefffohl mentioned in #27 , the functionality for parsing large files is much improved by that PR, but for a really big file (60MB+) the browser gets on the knees.
To improve this, we could
MAX_SIZE
field and if the graph is larger than thatThe text was updated successfully, but these errors were encountered: