Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On really big files (60MB) the browser stalls #56

Closed
breznak opened this issue Dec 14, 2015 · 4 comments
Closed

On really big files (60MB) the browser stalls #56

breznak opened this issue Dec 14, 2015 · 4 comments

Comments

@breznak
Copy link
Member

breznak commented Dec 14, 2015

As @jefffohl mentioned in #27 , the functionality for parsing large files is much improved by that PR, but for a really big file (60MB+) the browser gets on the knees.

To improve this, we could

@jefffohl
Copy link
Member

I am not sure which option is the best. I am leaning towards the windowing option. We can post an alert stating that the data is being windowed, and allow the user to turn that off, and load the entire file if they really want to try that - knowing that it might crash the browser.

What option do you think users would prefer?

@breznak
Copy link
Member Author

breznak commented Dec 14, 2015

@jefffohl I don't know either. The widowing option will be used anyway for the streaming data, so we can start with that and enable #43 later?

@jefffohl
Copy link
Member

jefffohl commented Jan 5, 2016

@breznak - we can automatically use windowing on files over a certain size. I am going to arbitrarily set this to 5MB.

jefffohl added a commit to jefffohl/nupic.visualizations that referenced this issue Jan 6, 2016
breznak added a commit that referenced this issue Jan 6, 2016
Addresses #56. Large files will be windowed - whether they are local or remote.
@breznak
Copy link
Member Author

breznak commented Jan 6, 2016

Fixed with #64 , large files use 5MB size window

@breznak breznak closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants