Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot override format for listItem #147

Open
phw opened this issue Nov 24, 2017 · 0 comments
Open

Cannot override format for listItem #147

phw opened this issue Nov 24, 2017 · 0 comments

Comments

@phw
Copy link

phw commented Nov 24, 2017

Currently it is not possible to override the format for listItem, as lib/formatter.js calls formatListItem internally.

The only workaround is to override unorderedList or orderedList
jackellenberger pushed a commit to jackellenberger/node-html-to-text that referenced this issue May 11, 2018
Allow recursive custom formatters
c7a2e1e 
* Resolves html-to-text#147
* When format functions are called internally within formatter.js
  it is not possible to override the custom logic. This changes that
  functionality and allows users to choose whether they want the
  default formatter to be used internally or their own formatters
  supplied in the options object.
@jackellenberger jackellenberger mentioned this issue May 11, 2018
Open
@jackellenberger jackellenberger mentioned this issue Aug 3, 2018
Merged
jackellenberger added a commit to jackellenberger/node-html-to-text that referenced this issue Aug 3, 2018
@jackellenberger
Allow recursive custom formatters (#2)
05c5496 
* Allow recursive custom formatters

* Resolves html-to-text#147
* When format functions are called internally within formatter.js
  it is not possible to override the custom logic. This changes that
  functionality and allows users to choose whether they want the
  default formatter to be used internally or their own formatters
  supplied in the options object.

* fixup - reduce line length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phw