Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to py.test and take advantage of it #182

Closed
3 of 5 tasks
gsnedders opened this issue Apr 6, 2015 · 6 comments
Closed
3 of 5 tasks

Move to py.test and take advantage of it #182

gsnedders opened this issue Apr 6, 2015 · 6 comments
Milestone

Comments

@gsnedders
Copy link
Member

gsnedders commented Apr 6, 2015

We want to move to py.test so that:

  • we can select to only run parser tests with one tree builder (and tree walker tests with only one tree walker, etc.)
  • we can make use of the plugin API to create a means of dumping test failures and build support for expected failures into the testsuites from html5lib-tests
  • it is easier to create nicer error messages
  • better support for skipped and expected failures so we can walk towards having a constant number of tests across all platforms, optionally skipped

https://github.com/gsnedders/html5lib-python/tree/expected_failures_pytest is my current WIP branch implementing this.

Status:

Needed to fix failures:

  • Make sure tests from generators run in a deterministic order
  • Use pytest-expect

The rest:

@gsnedders gsnedders added this to the 0.9999 milestone Apr 6, 2015
@gsnedders gsnedders self-assigned this Apr 6, 2015
@gsnedders gsnedders modified the milestones: 0.9999, 0.99999 Apr 29, 2015
@gsnedders
Copy link
Member Author

I've, uh, been totally over-engineering this. Something along the lines of https://github.com/dmerejkowsky/pytest-runfailed/blob/master/pytest_runfailed.py would work fine.

@gsnedders
Copy link
Member Author

We've now landed the stuff most needed here. Yay!

@gsnedders gsnedders removed their assignment Sep 5, 2017
@willkg willkg added this to the 1.0 milestone Oct 3, 2017
@willkg
Copy link
Contributor

willkg commented Nov 9, 2017

I think there are three things left to do here:

  1. Update html5lib/tests/README to talk about pytest and not notes.
  2. Move tokenizer and serialiser tests over to generating test objects from the JSON files.
  3. Refactor support.py.

I can do the 1. I need more details on what 2 and 3 entail. Part of me thinks we should split 2 and 3 into separate issues.

@gsnedders Is that ok with you?

@gsnedders
Copy link
Member Author

@willkg lgtm

@willkg
Copy link
Contributor

willkg commented Nov 27, 2017

I split 2 and 3 into separate issues and did a PR to remove that one bit about nose in the tests README. After that PR lands, I'll close this out.

@willkg
Copy link
Contributor

willkg commented Nov 29, 2017

PR #366 landed and the other two things were spun off as separate issues, so everything outstanding is covered elsewhere now. Closing this out.

@willkg willkg closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants