Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a new release #577

Open
mgorny opened this issue Jan 24, 2024 · 9 comments
Open

Please make a new release #577

mgorny opened this issue Jan 24, 2024 · 9 comments

Comments

@mgorny
Copy link

mgorny commented Jan 24, 2024

Could you please make a new release? 1.1 is from 2020, and since then there have been already 2 commits fixing compatibility with new pytest versions.

@Mic92
Copy link

Mic92 commented Sep 9, 2024

Friendly ping.

@ashleysommer
Copy link

@mgorny @Mic92

I've published my own release here: https://pypi.org/project/html5lib-modern/
It is the main branch v1.2-dev code as-of today, plus the "remove python2" changes plus the "drop six" changes.
It also includes a couple of tweaks of my own, including vendorizing "webencodings" library so we can include a modernised version of that, and this version of html5lib now has zero dependencies.
Additionally, the module is now packaged with a pyproject.toml file using the new PEP-517 pyPA build tooling.

@Mic92
Copy link

Mic92 commented Sep 25, 2024

Can you also do a release tag on github for reference? Thanks.

https://github.com/ashleysommer/html5lib-modern/

@a-detiste
Copy link

@ashleysommer your fork looks nice. Distributions that already package webencodings for other uses will have to devendor it but that's not an overwhelming task. (Or you want to maintain a fork of this too ?)

@ashleysommer
Copy link

ashleysommer commented Sep 26, 2024

@Mic92

Can you also do a release tag on github for reference? Thanks.

Thanks for the reminder. I forgot that crucial step.
Done now.
https://github.com/ashleysommer/html5lib-modern/releases/tag/v1.2.0

@a-detiste

Distributions that already package webencodings for other uses will have to devendor it but that's not an overwhelming task.

What other use does webencodings have outside of html5lib? It is a very small library (only 4 tiny files) and the project hasn't been updated in over 7 years.
My understanding is the only distributions packaging webencodings are for the purposes of enabling html5lib. Even if they want to keep webencodings available as a separate package, there is no need to de-vendor it from html5lib-modern, that doesn't achieve anything meaningful.

(Or you want to maintain a fork of this too ?)

No, the reason for including it within the html5lib-modern package is to avoid needing to maintain a separate fork of that too.

@Mic92
Copy link

Mic92 commented Sep 26, 2024

It only shouldn't conflict in the namespace. So it should be under the html5lib module namespace, which is the case here.

@ashleysommer
Copy link

ashleysommer commented Sep 26, 2024

That's right, it's namespace in html5lib-modern is html5lib.contrib.webencodings.

@a-detiste
Copy link

Here is for the record. I need to check these 3 other rdeps

reverse-depends  python3-webencodings
Reverse-Depends
===============
* python3-cssselect2
* python3-html5lib
* python3-meshtastic
* python3-tinycss2

@a-detiste
Copy link

Unlike what is stated on the release notes, webencodings doesn't need six.
Otherwise the changes are good but not needed.

I've uploaded html5lib 1.2

--- webencodings/__init__.py    2024-09-26 01:36:20.868981610 +0200
+++ /usr/lib/python3/dist-packages/webencodings/__init__.py     2017-04-05 22:16:48.000000000 +0200
@@ -12,12 +12,14 @@
 
 """
 
+from __future__ import unicode_literals
+
 import codecs
 
 from .labels import LABELS
 
 
-VERSION = '0.6-dev'
+VERSION = '0.5.1'
 
 
 # Some names in Encoding are not valid Python aliases. Remap these.
@@ -33,7 +35,7 @@
 def ascii_lower(string):
     r"""Transform (only) ASCII letters to lower case: A-Z is mapped to a-z.
 
-    :param string: A Unicode string.
+    :param string: An Unicode string.
     :returns: A new Unicode string.
 
     This is used for `ASCII case-insensitive
diff -ur webencodings/mklabels.py /usr/lib/python3/dist-packages/webencodings/mklabels.py
--- webencodings/mklabels.py    2024-09-26 01:36:20.868981610 +0200
+++ /usr/lib/python3/dist-packages/webencodings/mklabels.py     2016-05-22 22:39:07.000000000 +0200
@@ -11,7 +11,10 @@
 """
 
 import json
-from urllib.request import urlopen
+try:
+    from urllib import urlopen
+except ImportError:
+    from urllib.request import urlopen
 
 
 def assert_lower(string):
Seulement dans /usr/lib/python3/dist-packages/webencodings: __pycache__
diff -ur webencodings/tests.py /usr/lib/python3/dist-packages/webencodings/tests.py
--- webencodings/tests.py       2024-09-26 01:36:20.868981610 +0200
+++ /usr/lib/python3/dist-packages/webencodings/tests.py        2017-04-05 22:00:25.000000000 +0200
@@ -11,6 +11,8 @@
 
 """
 
+from __future__ import unicode_literals
+
 from . import (lookup, LABELS, decode, encode, iter_decode, iter_encode,
                IncrementalDecoder, IncrementalEncoder, UTF8)
 
diff -ur webencodings/x_user_defined.py /usr/lib/python3/dist-packages/webencodings/x_user_defined.py
--- webencodings/x_user_defined.py      2024-09-26 01:36:20.868981610 +0200
+++ /usr/lib/python3/dist-packages/webencodings/x_user_defined.py       2017-04-05 22:00:25.000000000 +0200
@@ -11,6 +11,8 @@
 
 """
 
+from __future__ import unicode_literals
+
 import codecs
 
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants