-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing MathML elements and attributes. #181
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/3950 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Kurt McKee updated the list for feedparser. I'm adding encoding/other attribute to keep in sync. See distler/venus@fdb788e#commitcomment-10724078 |
sighs. Is there any sane way to programmatically generate a list of MathML elements/attributes? Though I guess that doesn't work because there still needs to be some review to make sure they're safe (for the sanitizer). |
Well, it you want to generate the list of MathML attributes/elements, you can use the official RelaxNG schema: http://www.w3.org/Math/RelaxNG/ The HTML5 validator patches these schemas, but that should not change the list: https://github.com/validator/validator/tree/master/schema/mml3 |
@gsnedders This seems to have stalled... what's the plan here? |
@fred-wang Need to sit down and do a proper review of all the presentational MathML stuff to ensure there's nothing that could potentially break out of the inline box and take over the page. |
@gsnedders Here are some explanations if that can help to make progress. I would at least appreciate if the elements from 1) and 2) below and the associated attributes (notation and encoding) are added asap as they are used in real Web pages but unfortunately filtered out by Planet Venus. If you want, I can create a separate pull request to add them. Thanks.
|
'mmultiscripts', 'mn', 'mo', 'mover', 'mpadded', | ||
'mphantom', 'mprescripts', 'mroot', 'mrow', 'ms', | ||
'mscarries', 'mscarry', 'msgroup', 'msline', 'mstack', | ||
'mspace', 'msqrt', 'msrow', 'mstack' 'mstyle', 'msub', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mstack is added twice here :-(
External contributions do not seem welcome, so I'm closing this pull request and deleting my fork. |
(in particular this adds the semantics/annotation/annotation-xml elements required to fix a very old planet bug http://www.maths-informatique-jeux.com/blog/frederic/?post/2013/01/22/Analysis-of-Lithium-s-algorithm#c142)