Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package author and contributors #270

Merged

Conversation

Shinigami92
Copy link
Contributor

Partially fixes: #259

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

Give the main contributor some credits

Proposed changes:

  • Added main contributors to the package.json

👍 Thank you!

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #270 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #270   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            1      1           
  Lines            1      1           
======================================
  Hits             1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0338c5...7c7183a. Read the comment docs.

@thedaviddias thedaviddias self-requested a review August 27, 2018 11:16
Copy link
Member

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next, we can automate the update of this file.

@thedaviddias thedaviddias merged commit 14fd3aa into htmlhint:develop Aug 27, 2018
@Shinigami92 Shinigami92 deleted the package-author-and-contributors branch August 27, 2018 15:05
thedaviddias pushed a commit that referenced this pull request Sep 3, 2018
**Partially fixes**: #259 

- [x] Check the commit's or even all commits' message styles matches our requested structure.
- [x] Check your code additions will fail neither code linting checks nor unit test.

#### Short description of what this resolves:

Give the main contributor some credits

#### Proposed changes:

- Added main contributors to the package.json

👍 Thank you!
thedaviddias pushed a commit that referenced this pull request Sep 3, 2018
**Partially fixes**: #259 

- [x] Check the commit's or even all commits' message styles matches our requested structure.
- [x] Check your code additions will fail neither code linting checks nor unit test.

#### Short description of what this resolves:

Give the main contributor some credits

#### Proposed changes:

- Added main contributors to the package.json

👍 Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants