Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move rules into dedicated attribute #476

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

Shinigami92
Copy link
Contributor

Short description of what this resolves:

We want to support a new configuration structure that can handle more than just the rules
So we have to move the rules to a dedicated rules attribute

Proposed changes:

  • Move rules into dedicated attribute "rules": { /* ... */ }

@Shinigami92 Shinigami92 added the enhancement Functionality that enhances existing features label Jun 30, 2020
@Shinigami92 Shinigami92 requested a review from thedaviddias June 30, 2020 15:44
@Shinigami92 Shinigami92 self-assigned this Jun 30, 2020
@Shinigami92 Shinigami92 changed the title Move rules into dedicated attribute feat: move rules into dedicated attribute Jun 30, 2020
@Shinigami92
Copy link
Contributor Author

Shinigami92 commented Jun 30, 2020

@thedaviddias Ready for review
I created two commits to simplify the review
So you only have to look at the first commit because the second commit (test update) is very boring 😉

Copy link
Member

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shinigami92 Shinigami92 merged commit 0705c1f into beta Jul 6, 2020
@Shinigami92 Shinigami92 deleted the feat/move-rules-into-dedicated-attribute branch July 6, 2020 14:59
@Shinigami92 Shinigami92 linked an issue Jul 6, 2020 that may be closed by this pull request
8 tasks
Shinigami92 added a commit that referenced this pull request Jul 8, 2020
* feat: move rules into dedicated attribute

* test: update tests
Shinigami92 added a commit that referenced this pull request Jul 10, 2020
* feat: move rules into dedicated attribute

* test: update tests
Shinigami92 added a commit that referenced this pull request Jul 10, 2020
* feat: move rules into dedicated attribute

* test: update tests
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([4e17338](4e17338))

### Continuous Integration

* trigger major bump ([be0b2af](be0b2af))

### Features

* move rules into dedicated attribute ([#476](#476)) ([c9fb2c3](c9fb2c3))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))

### BREAKING CHANGES

* Rules have a new structure
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
# [1.0.0-beta.1](v0.14.1...v1.0.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([4e17338](4e17338))

### Continuous Integration

* trigger major bump ([be0b2af](be0b2af))

### Features

* move rules into dedicated attribute ([#476](#476)) ([c9fb2c3](c9fb2c3))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))

### BREAKING CHANGES

* Rules have a new structure
Shinigami92 added a commit that referenced this pull request Jul 10, 2020
* feat: move rules into dedicated attribute

* test: update tests
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
# [0.15.0-beta.1](v0.14.1...v0.15.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([93eb5c8](93eb5c8))

### Features

* move rules into dedicated attribute ([#476](#476)) ([4d37821](4d37821))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))
thedaviddias pushed a commit that referenced this pull request Jul 10, 2020
# [0.15.0-beta.1](v0.14.1...v0.15.0-beta.1) (2020-07-10)

### Bug Fixes

* remove duplicate changelog ([#474](#474)) ([93eb5c8](93eb5c8))

### Features

* move rules into dedicated attribute ([#476](#476)) ([4d37821](4d37821))
* new configuration structure ([#445](#445)) ([0b007b3](0b007b3))
thedaviddias pushed a commit that referenced this pull request Jun 14, 2021
* feat: move rules into dedicated attribute

* test: update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite configuration structure
2 participants