Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config attribute extends #489

Open
wants to merge 9 commits into
base: beta
Choose a base branch
from

Conversation

Shinigami92
Copy link
Contributor

@Shinigami92 Shinigami92 commented Jul 8, 2020

Short description of what this resolves:

We want to support a extendable configuration file
So we introduce a new configuration attribute extends that behave like eslint's extends

Proposed changes:

  • Add new attribute extends in configuration

Tasks:

  • add extension ruleset map
  • read new configuration structure
  • pass config through to verify
  • add tests
  • define recommended ruleset

@Shinigami92 Shinigami92 added the feature request Functionality that introduces a new feature label Jul 8, 2020
@Shinigami92 Shinigami92 requested a review from thedaviddias July 8, 2020 18:15
@Shinigami92 Shinigami92 self-assigned this Jul 8, 2020
@Shinigami92 Shinigami92 changed the base branch from master to beta July 8, 2020 18:15
@Shinigami92 Shinigami92 linked an issue Jul 8, 2020 that may be closed by this pull request
8 tasks
@Shinigami92 Shinigami92 marked this pull request as ready for review July 10, 2020 17:40
@Shinigami92
Copy link
Contributor Author

@thedaviddias Ready for review! 🎉

At first, you can only focus on changes to the source files
Then, if you want, also look at the test files

We are getting closer to the release of version 1.0.0 😃

@Shinigami92 Shinigami92 force-pushed the feat/add-config-attribute-extends branch from 49f3549 to 59d55ca Compare July 10, 2020 18:41
@Shinigami92 Shinigami92 force-pushed the beta branch 2 times, most recently from 598f5c6 to e459672 Compare July 10, 2020 21:32
@Shinigami92 Shinigami92 force-pushed the feat/add-config-attribute-extends branch from 59d55ca to a763b2e Compare July 10, 2020 21:34
@Shinigami92 Shinigami92 added core Relates to HTMLHint's core APIs and features and removed core Relates to HTMLHint's core APIs and features labels Jul 14, 2020
@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Sep 12, 2020
@stale stale bot closed this Sep 26, 2020
@Schweinepriester
Copy link

This was automatically closed without conclusion; extendable configuration is still desirable imho.

@nschonni nschonni reopened this Nov 24, 2021
@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #489 (59d55ca) into beta (e459672) will not change coverage.
The diff coverage is n/a.

❗ Current head 59d55ca differs from pull request most recent head a763b2e. Consider uploading reports for the commit a763b2e to get more accurate results
Impacted file tree graph

@@     Coverage Diff     @@
##   beta   #489   +/-   ##
===========================
===========================

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e459672...a763b2e. Read the comment docs.

@gitrequests
Copy link

Configuration merge is still not available?

@stale
Copy link

stale bot commented Mar 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Mar 10, 2022
@Schweinepriester
Copy link

Still think this is very desirable, shouldn't be closed and get keep-unstale.

@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Mar 13, 2022
@nschonni nschonni added the keep-unstale The issue will not be marked as stale by the stale-bot label Mar 13, 2022
@ghaschel
Copy link

ghaschel commented Oct 6, 2022

No news on this? This is a must-have feature in every linter imho.

@donroyco
Copy link

donroyco commented Feb 6, 2023

Any update on this PR? It would be really helpful when this functionality lands in HTMLHint.

@Kristinita
Copy link

Are there any chances that this feature will be implemented to HTMLHint?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Functionality that introduces a new feature keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite configuration structure
7 participants