Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add types to package.json #865

Closed
wants to merge 2 commits into from
Closed

feat: Add types to package.json #865

wants to merge 2 commits into from

Conversation

martin-badin
Copy link

This PR solves to use types in typescript projects

@github-actions github-actions bot added core Relates to HTMLHint's core APIs and features dependencies Pull requests that update a dependency file labels Jan 14, 2022
@martin-badin martin-badin changed the title Add types to package.json feat: Add types to package.json Jan 14, 2022
@martin-badin
Copy link
Author

@coliff Could you please review?

@martin-badin martin-badin mentioned this pull request Jan 14, 2022
Closed
6 tasks
@martin-badin martin-badin mentioned this pull request Jan 14, 2022
Open
@coliff coliff requested a review from nschonni January 14, 2022 12:26
@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #865 (a92cbf1) into master (b8f685b) will not change coverage.
The diff coverage is n/a.

❗ Current head a92cbf1 differs from pull request most recent head 91451c3. Consider uploading reports for the commit 91451c3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files           1        1           
  Lines         901      901           
  Branches      191      191           
=======================================
  Hits          869      869           
  Misses         13       13           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f685b...91451c3. Read the comment docs.

@martin-badin
Copy link
Author

@nschonni please review. Thanks

nschonni
nschonni reviewed Jan 27, 2022
View reviewed changes
@martin-badin martin-badin requested a review from nschonni February 4, 2022 16:48
@stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Apr 6, 2022
@nschonni nschonni removed the bot:stale Issue marked as stale because there was no activity label Apr 7, 2022
@stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Jun 11, 2022
@coliff coliff removed the bot:stale Issue marked as stale because there was no activity label Jun 11, 2022
@stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Aug 11, 2022
@coliff coliff removed the bot:stale Issue marked as stale because there was no activity label Sep 6, 2022
@coliff coliff added the keep-unstale The issue will not be marked as stale by the stale-bot label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedaviddias thedaviddias Awaiting requested review from thedaviddias thedaviddias is a code owner

@nschonni nschonni Awaiting requested review from nschonni

Assignees
No one assigned
Labels
core Relates to HTMLHint's core APIs and features dependencies Pull requests that update a dependency file keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-badin @nschonni @coliff