Add support for Access-Control-Expose-Headers using 'cors' configurat… #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been inactive for 360 days |
thornjad
requested changes
Aug 20, 2021
Member
thornjad
left a comment
thornjad
left a comment
There was a problem hiding this comment.
I like the way this looks! Only two items left to do:
- Merge
masteragain, there are new tests to run on this PR - Add this header to the CORS test in
test/main.test.js
thornjad
added
enhancement
patch version
ben-z
added a commit
to ben-z/http-server
that referenced
this pull request
Apr 11, 2023
…s to CORS-safelisted headers Similar to this (stale) PR: http-party#546 Resolves http-party#545 Usable for cruise-automation/webviz#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #545. Supply 'corser' with a similar set of responseHeaders from the 'cors' options.