[fix minor] Prevent crashes from attempting to remove listeners more …

…than once when proxying websocket requests.
http-party · Mar 9, 2013 · a681493 · a681493
1 parent 2055d0c
commit a681493
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/lib/node-http-proxy/http-proxy.js b/lib/node-http-proxy/http-proxy.js
@@ -472,6 +472,8 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, buffer)
   // the appropriate events.
   //
   function onUpgrade (reverseProxy, proxySocket) {
+    var detached;
+
     if (!reverseProxy) {
       proxySocket.end();
       socket.end();
@@ -543,12 +545,15 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, buffer)
     // from `reverseProxy` and `proxySocket`.
     //
     function detach() {
-      proxySocket.destroySoon();
-      proxySocket.removeListener('end', listeners.onIncomingClose);
-      proxySocket.removeListener('data', listeners.onIncoming);
-      reverseProxy.incoming.socket.destroySoon();
-      reverseProxy.incoming.socket.removeListener('end', listeners.onOutgoingClose);
-      reverseProxy.incoming.socket.removeListener('data', listeners.onOutgoing);
+      if (!detached) {
+        detached = true;
+        proxySocket.destroySoon();
+        proxySocket.removeListener('end', listeners.onIncomingClose);
+        proxySocket.removeListener('data', listeners.onIncoming);
+        reverseProxy.incoming.socket.destroySoon();
+        reverseProxy.incoming.socket.removeListener('end', listeners.onOutgoingClose);
+        reverseProxy.incoming.socket.removeListener('data', listeners.onOutgoing);
+      }
     }
 
    //